Fix "Cannot find module" e2e test failure #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like some E2E tests are still failing? |
|
The existing errors are "Condition not reached within timeout." and timeout errors are usually transient |
alrod
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Node.js test in the Core tools e2e integration build is currently failing with an error like this:
The bug only happens for the webpacked version of the worker and it came about because the webpack config hard-coded a file name and I moved some code out of that file in #576. The code in question does a 'require' on the user's scriptFilePath which is a dynamic value that webpack can't/shouldn't handle. I improved the webpack config so that we can use a simple comment in the code to tell webpack to ignore that 'require'. This should prevent similar bugs from happening in the future regardless of where we put this code.