Switch context.res type to HttpResponse #550
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejizba
reviewed
Mar 4, 2022
| /** | ||
| * HTTP response object. Provided to your function when using HTTP Bindings. | ||
| */ | ||
| res?: { |
There was a problem hiding this comment.
I don't see this change happening any time soon. Unless you disagree, I think that means this should be tracked as an issue instead of a PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default type of
context.resfrom{ [key: string]: any }(very generic and not very helpful) to leverage the newHttpResponetypes introduced in #529. This is a breaking change, so was left to a separate PR. See the discussion there for why this is a breaking change and the different workarounds. Moving discussion here on when/how/if we want to make this change.