Skip to content

Conversation

@Francisco-Gamino
Copy link
Contributor

Issue describing the changes in this PR

This PR contains the following change:

  • Update PowerShell 7.4 Worker Version to 4.0.2975
  • Update PowerShell 7.2 Worker Version to 4.0.2974
  • Update PowerShell 7.0 Worker Version to 4.0.2973

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

Copy link
Member

@kshyju kshyju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any E2E test we should update/add to include this new args?

@Francisco-Gamino
Copy link
Contributor Author

Francisco-Gamino commented Sep 12, 2023

Are there any E2E test we should update/add to include this new args?

@kshyju -- We do not have any PowerShell specific end to end tests that validate arg parsing.

The only end to end tests that have to validate the args parsing are located here:

public void DefaultWorkerProcessFactory_Returns_ExpectedProcess(WorkerContext workerContext)
{
Environment.SetEnvironmentVariable("TestEnv", "TestVal");
DefaultWorkerProcessFactory defaultWorkerProcessFactory = new DefaultWorkerProcessFactory(_testEnvironment, _loggerFactory);
Process childProcess = defaultWorkerProcessFactory.CreateWorkerProcess(workerContext);
var expectedEnvVars = workerContext.EnvironmentVariables;
var actualEnvVars = childProcess.StartInfo.EnvironmentVariables;
var parentProessEnvVars = Environment.GetEnvironmentVariables();
Assert.True(expectedEnvVars.Count + parentProessEnvVars.Count == actualEnvVars.Count);
foreach (var envVar in expectedEnvVars)
{
Assert.Equal(expectedEnvVars[envVar.Key], actualEnvVars[envVar.Key]);
}
if (workerContext is RpcWorkerContext)
{
Assert.Equal(" httpvalue1 TestVal httpvalue2 --host localhost --port 80 --workerId testWorkerId --requestId testId --grpcMaxMessageLength 2147483647", childProcess.StartInfo.Arguments);
}
else
{
Assert.Equal(" httpvalue1 TestVal httpvalue2", childProcess.StartInfo.Arguments);
}
childProcess.Dispose();
Environment.SetEnvironmentVariable("TestEnv", string.Empty);
}

Could you please include new test(s) that validate the new args with your code change? Thank you!

@Francisco-Gamino
Copy link
Contributor Author

@microsoft-github-policy-service agree

@kshyju kshyju closed this Sep 13, 2023
@kshyju kshyju reopened this Sep 13, 2023
@kshyju kshyju merged commit 7b8130c into dev Sep 13, 2023
@kshyju kshyju deleted the Francisco-Gamino/upgrade-ps-language-workers branch September 13, 2023 02:53
@VpOfEngineering VpOfEngineering mentioned this pull request Oct 12, 2023
8 tasks
VpOfEngineering pushed a commit that referenced this pull request Oct 12, 2023
… version 4.0.2974), and 7.4 (to version 4.0.2975) (#9528)

* Upgrade PowerShell language worker 7.4 to 4.0.2975

* Upgrade PowerShell language worker 7.2 to 4.0.2974

* Upgrade PowerShell language worker 7.0 to 4.0.2973

* Update release notes
VpOfEngineering added a commit that referenced this pull request Oct 12, 2023
* Updating patch version

* Sending command line args with functions- prefix to prevent conflicts (#9514)

* Sending a second copy of command line args with "FUNCTIONS_" prefix

* Cleanup

* Sending a second copy of command line args with "FUNCTIONS_" prefix

* switched to functions- prefix

* Removed duplicate port from functions_uri

* Switching to kebab case for the new args

* Update test

* Update native placeholder package to handle new args

* Update release notes.

* Limit dotnet-isolated specialization to 64 bit host process (#9553)

* Skipping native placeholder specialization if host is not 64 bit process

* formatting linting fix

* Stylecop fix.

* fix indentation

* Adding E2E test.

* Improving log message.

* Switch from LogDebug to LogInformation

* Fix tests to reflect logging changes

* Logging with EventId

* Logging using an event name

* Updated release notes after rebase merge

* Handling env reload response from native placeholder for failure case. (#9602)

* Handling env reload response from native placeholder for failure case.

* Almost working except one test needs cleanup

* Cleanup

* Cleanup

* Fixing Worker.Extensions.Http package version to align with Http.AspNetCore package.

* Logging error as it is received from the worker.

* DotNetIsolatedNativeHost package to 1.0.2

* Inlining a variable (Reverting to previous version)

* Updating release notes for 4.27.5

* Update PowerShell Language Workers 7.0 (to version 4.0.2973), 7.2 (to version 4.0.2974), and 7.4 (to version 4.0.2975)  (#9528)

* Upgrade PowerShell language worker 7.4 to 4.0.2975

* Upgrade PowerShell language worker 7.2 to 4.0.2974

* Upgrade PowerShell language worker 7.0 to 4.0.2973

* Update release notes

* Update Java Worker Version to 2.13.0 (#9544)

* Update Java Worker Version to 2.13.0

* Update release_notes.md for Java worker

---------

Co-authored-by: AzureFunctionsJava <[email protected]>

---------

Co-authored-by: azfuncgh <[email protected]>
Co-authored-by: Shyju Krishnankutty <[email protected]>
Co-authored-by: Francisco Gamino <[email protected]>
Co-authored-by: Shreyas Gopalakrishna <[email protected]>
Co-authored-by: AzureFunctionsJava <[email protected]>
VpOfEngineering added a commit that referenced this pull request Nov 16, 2023
* Updating patch version

* Sending command line args with functions- prefix to prevent conflicts (#9514)

* Sending a second copy of command line args with "FUNCTIONS_" prefix

* Cleanup

* Sending a second copy of command line args with "FUNCTIONS_" prefix

* switched to functions- prefix

* Removed duplicate port from functions_uri

* Switching to kebab case for the new args

* Update test

* Update native placeholder package to handle new args

* Update release notes.

* Limit dotnet-isolated specialization to 64 bit host process (#9553)

* Skipping native placeholder specialization if host is not 64 bit process

* formatting linting fix

* Stylecop fix.

* fix indentation

* Adding E2E test.

* Improving log message.

* Switch from LogDebug to LogInformation

* Fix tests to reflect logging changes

* Logging with EventId

* Logging using an event name

* Updated release notes after rebase merge

* Handling env reload response from native placeholder for failure case. (#9602)

* Handling env reload response from native placeholder for failure case.

* Almost working except one test needs cleanup

* Cleanup

* Cleanup

* Fixing Worker.Extensions.Http package version to align with Http.AspNetCore package.

* Logging error as it is received from the worker.

* DotNetIsolatedNativeHost package to 1.0.2

* Inlining a variable (Reverting to previous version)

* Updating release notes for 4.27.5

* Update PowerShell Language Workers 7.0 (to version 4.0.2973), 7.2 (to version 4.0.2974), and 7.4 (to version 4.0.2975)  (#9528)

* Upgrade PowerShell language worker 7.4 to 4.0.2975

* Upgrade PowerShell language worker 7.2 to 4.0.2974

* Upgrade PowerShell language worker 7.0 to 4.0.2973

* Update release notes

* Update Java Worker Version to 2.13.0 (#9544)

* Update Java Worker Version to 2.13.0

* Update release_notes.md for Java worker

---------

Co-authored-by: AzureFunctionsJava <[email protected]>

---------

Co-authored-by: azfuncgh <[email protected]>
Co-authored-by: Shyju Krishnankutty <[email protected]>
Co-authored-by: Francisco Gamino <[email protected]>
Co-authored-by: Shreyas Gopalakrishna <[email protected]>
Co-authored-by: AzureFunctionsJava <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants