Skip to content

Conversation

@liliankasem
Copy link
Member

@liliankasem liliankasem commented Jun 16, 2022

Logging WorkerMetadata information as a debug log and a metric event. Defaulting to information from worker config for language and runtime version

Issue describing the changes in this PR

resolves #8452

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Testing

Metric shows up in FunctionMetrics table:

Screen Shot 2022-06-17 at 3 00 20 PM

Log shows up in FunctionLogs table:

Screen Shot 2022-06-17 at 2 59 27 PM

@liliankasem liliankasem changed the title Log WorkerMetadata as custom properties Log WorkerMetadata as a custom property & metric Jun 17, 2022
@liliankasem liliankasem changed the title Log WorkerMetadata as a custom property & metric Parse and log WorkerMetadata information Jun 17, 2022
@liliankasem liliankasem force-pushed the liliankasem/log-workermetadata branch from 4a4bad0 to 9f77e9b Compare June 23, 2022 16:27
@liliankasem liliankasem merged commit 1bf8720 into dev Jun 23, 2022
@liliankasem liliankasem deleted the liliankasem/log-workermetadata branch June 23, 2022 16:46
@kashimiz
Copy link
Contributor

/backport to v3.x

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@kashimiz backporting to v3.x failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Log WorkerMetadata as custom properties
Applying: Log metric
error: sha1 information is lacking or useless (src/WebJobs.Script.Grpc/Channel/GrpcWorkerChannel.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Log metric
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@liliankasem liliankasem mentioned this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log WorkerMetadata details from the WorkerInitResponse message

5 participants