Print warning when AddJsonFile is called with "local.settings.json" #2777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BogdanYarotsky
changed the title
Author
|
@microsoft-github-policy-service agree |
liliankasem
reviewed
Oct 21, 2024
liliankasem
reviewed
Oct 28, 2024
docs/analyzer-rules/AZFW0016.md
Outdated
| @@ -0,0 +1,27 @@ | |||
| # AZFW0016: Redundant usage of local.settings.json in the worker configuration | |||
Member
There was a problem hiding this comment.
AZFW0016 already exists (recently merged) - can you make this AZFW0017?
Author
|
Hi, sure, I will update the PR soon. |
microsoft-github-policy-service
bot
added
Needs: Attention 👋
and removed
Needs: Author Feedback
no-recent-activity
no recent activity
labels
Author
|
Hello @liliankasem, I've updated the ID of the warning. Please let me know if any other changes are needed. Thank you for the review! |
|
This seems useful could we get an update here? @liliankasem (@kshyju @mattchenderson) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #613
Pull request checklist
release_notes.mdAdditional information.
Hi @fabiocav, this is my first pull request in this repository. I've added a bunch of unit tests and documentation for the new analyzer. Please let me know what you think about this PR and what else should be added to it.
Many Thanks!
Bogdan