fix: Add Ifname to IPConfigsRequest from CNI #4053
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a missing field assignment in the CNI IPAM invoker by adding the Ifname field to the IPConfigsRequest structure. This ensures that the interface name from CNI arguments is properly passed to the Container Network Service (CNS) when requesting IP configurations.
- Added Ifname field assignment to IPConfigsRequest in CNS IPAM invoker
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
i'm skeptical of this. why has it never needed to be set before, and what's different that requires it to be set now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes: