Add default route only when skipdefaultroutes flag to false in dualni… #4043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tamilmani1989
approved these changes
Oct 1, 2025
tamilmani1989
requested changes
Oct 1, 2025
Co-authored-by: tamilmani1989 <[email protected]> Signed-off-by: Paul Yu <[email protected]>
Co-authored-by: tamilmani1989 <[email protected]> Signed-off-by: Paul Yu <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds conditional logic to prevent default routes from being added when the SkipDefaultRoutes flag is set to true in dual NIC scenarios. This prevents duplicate default routes from being given to the Host Network Service (HNS).
Key changes:
- Extracted default route creation logic into a reusable function
- Added conditional check for
SkipDefaultRoutesflag before adding default routes - Enhanced test coverage with a new test case for the skip scenario
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cni/network/multitenancy.go | Refactored default route logic into addDefaultRoute method and added conditional check for SkipDefaultRoutes flag |
| cni/network/multitenancy_test.go | Updated existing test case name and added new test case to verify behavior when SkipDefaultRoutes=true |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…c scenario
Reason for Change:
This PR is to add the default route only when skipdefaultroutes flag set to false in dualnic scenario
Issue Fixed:
Requirements:
Notes: