feat: Add App Gateway Subnet ID as a field to the Overlay Extension Config CRD #3925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Application Gateway subnet configuration to the Overlay Extension Config CRD by introducing a new appGatewaySubnetID field. This enables specifying a dedicated subnet for Application Gateway that can reach routing domain IP addresses, providing more granular network configuration options.
- Added
appGatewaySubnetIDfield to the CRD specification with immutability validation - Updated the Go types to include the new field with appropriate validation rules
- Enhanced YAML formatting for better readability in description fields
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crd/overlayextensionconfig/manifests/acn.azure.com_overlayextensionconfigs.yaml |
Updates CRD manifest to include the new appGatewaySubnetID field with validation rules and improved formatting |
crd/overlayextensionconfig/api/v1alpha1/overlayextensionconfig_types.go |
Adds the AppGatewaySubnetID field to the Go struct with immutability validation |
Comments suppressed due to low confidence (2)
crd/overlayextensionconfig/api/v1alpha1/overlayextensionconfig_types.go:37
- The removal of the
+kubebuilder:validation:Optionalcomment appears unintentional. This annotation helps clarify that the field is optional and should be retained for consistency and clarity.
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
/azp Azure Container Networking PR |
|
Command 'Azure' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rejain456
previously approved these changes
Aug 12, 2025
crd/overlayextensionconfig/api/v1alpha1/overlayextensionconfig_types.go
Outdated
Show resolved
Hide resolved
kmurudi
reviewed
Aug 12, 2025
kmurudi
previously approved these changes
Aug 12, 2025
…king existing clusters where this field is not populated
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
thatmattlong
approved these changes
Aug 12, 2025
kmurudi
approved these changes
Aug 12, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 13, 2025
…onfig CRD (#3925) * feat: Add App Gateway Subnet ID as a field to the Overlay Extension Config CRD * fix: Fixed the lint error from the pipeline * fix: Fixed the CRD Generation error from the pipelines * fix: Updated the name to be specific that we require the subnet Guid and not ARM ID * fix: Keeping the IP Range field as optional * fix: Making the App Gateway Subnet ID field as optional to avoid breaking existing clusters where this field is not populated * fix: Updated CRD to fix CRDGen Error
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
NihaNallappagari
pushed a commit
to NihaNallappagari/azure-container-networking
that referenced
this pull request
Sep 4, 2025
…onfig CRD (Azure#3925) * feat: Add App Gateway Subnet ID as a field to the Overlay Extension Config CRD * fix: Fixed the lint error from the pipeline * fix: Fixed the CRD Generation error from the pipelines * fix: Updated the name to be specific that we require the subnet Guid and not ARM ID * fix: Keeping the IP Range field as optional * fix: Making the App Gateway Subnet ID field as optional to avoid breaking existing clusters where this field is not populated * fix: Updated CRD to fix CRDGen Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
feat: Add App Gateway Subnet ID as a field to the Overlay Extension Config CRD
Issue Fixed:
N/A
Requirements:
Notes: