feat: add AppGatewaySubnetID field to OverlayExtensionConfig CRD #3889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Application Gateway subnet connectivity to the OverlayExtensionConfig CRD by introducing a new AppGatewaySubnetID field. The change extends routing domain connectivity to AGIC/AGC subnets while maintaining backward compatibility with the existing extensionIPRange field.
- Adds
appGatewaySubnetIDfield to OverlayExtensionConfigSpec struct - Implements immutable validation constraint on the new field
- Updates CRD manifest to include the new field definition
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crd/overlayextensionconfig/api/v1alpha1/overlayextensionconfig_types.go | Adds AppGatewaySubnetID field to OverlayExtensionConfigSpec with validation annotations |
| crd/overlayextensionconfig/manifests/acn.azure.com_overlayextensionconfigs.yaml | Updates CRD manifest with appGatewaySubnetID field schema and validation rules |
crd/overlayextensionconfig/api/v1alpha1/overlayextensionconfig_types.go
Outdated
Show resolved
Hide resolved
nairashu
approved these changes
Aug 5, 2025
k-routhu
approved these changes
Aug 8, 2025
nairashu
approved these changes
Aug 12, 2025
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
OverlayExtensionConfig (OEC) was designed specifically to work with AGIC/AGC subnets. We want to extend Routing Domain connectivity to these subnets only. To avoid breaking changes (such as removing existing
extensionIPRangefield from OEC CRD), add a newappGatewaySubnetIDfield to OEC CRD.Issue Fixed:
Requirements:
Notes: