support feature flags #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avanigupta
reviewed
Jun 4, 2024
avanigupta
reviewed
Jun 4, 2024
avanigupta
reviewed
Jun 4, 2024
avanigupta
reviewed
Jun 4, 2024
avanigupta
reviewed
Jun 4, 2024
| * | ||
| * @remarks | ||
| * keyFilter of selector will be prefixed with "appconfig.featureflag/" when request is sent. | ||
| * If no selectors are specified then no feature flags will be retrieved. |
There was a problem hiding this comment.
If no selectors are specified, shouldn't we load all Feature Flags with null label? That's what we do for key-values too.
There was a problem hiding this comment.
Per discussion, for feature flags we expect customers to explicitly specify selectors.
There was a problem hiding this comment.
Should we throw an error if FeatureFlagOptions.enabled is true but selectors are not provided?
There was a problem hiding this comment.
I agree, as it makes no sense to enable feature flags but load nothing. Throwing an error is better than silently loading nothing.
avanigupta
reviewed
Jun 4, 2024
avanigupta
reviewed
Jun 4, 2024
avanigupta
reviewed
Jun 4, 2024
Closed
Co-authored-by: Avani Gupta <[email protected]>
…ovider into yanzh/fm
Eskibear
changed the base branch from
feature-management
to
feature/feature-management
avanigupta
reviewed
Jun 11, 2024
avanigupta
reviewed
Jun 11, 2024
avanigupta
reviewed
Jun 11, 2024
avanigupta
reviewed
Jun 18, 2024
Eskibear
commented
Jun 26, 2024
avanigupta
reviewed
Jul 24, 2024
avanigupta
reviewed
Jul 28, 2024
avanigupta
reviewed
Jul 28, 2024
…ovider into yanzh/fm
avanigupta
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default feature flags are excluded and cannot be loaded. Only when
featureFlagOptions.enabledis true, it loads feature flags as a whole into a preserved keyfeature_management, according tofeatureFlagOptions.selectors. The refresh behavior is independently controlled byfeatureFlagOptions.refresh.