Skip to content

Merge main to release/preview/v1 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 21, 2024
Merged

Merge main to release/preview/v1 #50

merged 17 commits into from
Mar 21, 2024

Conversation

@Eskibear
Copy link
Member

@Eskibear Eskibear commented Mar 18, 2024

No description provided.

Eskibear and others added 15 commits December 18, 2023 10:37
@Eskibear
Add error handling delay in load function (#35)
f54e65b
@Eskibear
update doc comments per TSDoc standard (#36)
0adf2ff
@zhiyuanliang-ms
Update README for examples (#41)
85c0175 
* update readme

* add colon
@zhiyuanliang-ms
Unify the wording in README for examples (#42)
f881f58 
* update readme

* add colon

* rename sample to example

* update

* update

* update
@Eskibear
Hide private properties (#37)
5c66956
@Eskibear
Update labelFilter default value in SettingSelector (#43)
a076511
@Eskibear
Update @azure/identity version to 4.0.0 (#39)
5342021
@Eskibear
run mocha tests in parallel (#40)
68a8458
@Eskibear
Rename AzureAppConfigurationKeyVaultOptions to KeyVaultOptions (#44)
794559d
@Eskibear
Support dynamic refresh (#21)
277953d
@Eskibear
Add all-in-one pack script (#45)
e16bb8a
@Eskibear
chmod +x build-and-pack.sh (#47)
ed6688a
@Eskibear
Assert error messages and increase timeout for tests (#48)
02ded28
@Eskibear
rename members to adopt private properties (#46)
45c8266
@Eskibear
Refactor AzureAppConfiguration with new interfaces (#49)
28a5c69
@Eskibear Eskibear mentioned this pull request Mar 19, 2024
Merged
@avanigupta
Copy link
Member

avanigupta commented Mar 20, 2024

Reminder to merge this PR with a merge commit since we should preserve all feature commits in the release branch.

@Eskibear
Copy link
Member Author

Eskibear commented Mar 20, 2024 •
edited
Loading

I just revisited our public docs, and find there is usage of has(key) in sample code, which I think is valid.
But other public method of ReadonlyMap was removed when I changed it to impl IGettable. That would also break the use case. So, I would like to change it back to also impl ReadonlyMap which is compatible with interface IGettable. And it would not affect what we've done for FM lib.

@Eskibear Eskibear mentioned this pull request Mar 20, 2024
Merged
@Eskibear Eskibear merged commit f86cad2 into release/preview/v1 Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avanigupta avanigupta avanigupta approved these changes

@zhiyuanliang-ms zhiyuanliang-ms zhiyuanliang-ms approved these changes

@juniwang juniwang Awaiting requested review from juniwang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Eskibear @avanigupta @zhiyuanliang-ms