Skip to content

Rename AzureAppConfigurationKeyVaultOptions to KeyVaultOptions #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Rename AzureAppConfigurationKeyVaultOptions to KeyVaultOptions #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a3b346
Rename AzureAppConfigurationKeyVaultOptions to KeyVaultOptions
Eskibear Jan 4, 2024
05999fd
Update filename accordingly
Eskibear Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/AzureAppConfigurationOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Licensed under the MIT license.

import { AppConfigurationClientOptions } from "@azure/app-configuration";
import { AzureAppConfigurationKeyVaultOptions } from "./keyvault/AzureAppConfigurationKeyVaultOptions";
import { KeyVaultOptions } from "./keyvault/KeyVaultOptions";
import { SettingSelector } from "./types";

export const MaxRetries = 2;
Expand Down Expand Up @@ -34,5 +34,5 @@ export interface AzureAppConfigurationOptions {
/**
* Specifies options used to resolve Vey Vault references.
*/
keyVaultOptions?: AzureAppConfigurationKeyVaultOptions;
keyVaultOptions?: KeyVaultOptions;
}
4 changes: 2 additions & 2 deletions src/keyvault/AzureKeyVaultKeyValueAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

import { ConfigurationSetting, isSecretReference, parseSecretReference } from "@azure/app-configuration";
import { IKeyValueAdapter } from "../IKeyValueAdapter";
import { AzureAppConfigurationKeyVaultOptions } from "./AzureAppConfigurationKeyVaultOptions";
import { KeyVaultOptions } from "./KeyVaultOptions";
import { SecretClient, parseKeyVaultSecretIdentifier } from "@azure/keyvault-secrets";

export class AzureKeyVaultKeyValueAdapter implements IKeyValueAdapter {
Expand All @@ -13,7 +13,7 @@ export class AzureKeyVaultKeyValueAdapter implements IKeyValueAdapter {
private secretClients: Map<string, SecretClient>;

constructor(
private keyVaultOptions: AzureAppConfigurationKeyVaultOptions | undefined
private keyVaultOptions: KeyVaultOptions | undefined
) { }

public canProcess(setting: ConfigurationSetting): boolean {
Expand Down
2 changes: 1 addition & 1 deletion ...t/AzureAppConfigurationKeyVaultOptions.ts → src/keyvault/KeyVaultOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { SecretClient } from "@azure/keyvault-secrets";
/**
* Options used to resolve Key Vault references.
*/
export interface AzureAppConfigurationKeyVaultOptions {
export interface KeyVaultOptions {
/**
* Specifies the Key Vault secret client used for resolving Key Vault references.
*/
Expand Down