Skip to content

Conversation

@Eskibear
Copy link
Member

@Eskibear Eskibear commented Nov 8, 2023

This PR:

  • Rewrite test cases in TypeScript for better intellisense and type check. (*.test.js => *.test.ts)
  • Add a new tsconfig.test.json dedicated for compiling *.test.ts into *.test.js files. (tsconfig.json is responsible for buiding the project, and the common part is extracted into tsconfig.base.json)

@Eskibear Eskibear requested a review from avanigupta November 8, 2023 07:22
@Eskibear
Copy link
Member Author

Eskibear commented Nov 8, 2023

comments addressed, I'm merging it now.

@Eskibear Eskibear merged commit 5f35f2d into main Nov 8, 2023
@Eskibear Eskibear deleted the ts-test branch November 8, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants