Support comment in json key value #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ScriptProvider into zhiyuanliang/support-jsonc
RichardChen820
approved these changes
Jul 31, 2025
rossgrambo
reviewed
Jul 31, 2025
|
I see the tests aren't the same as the dotnet parser. Are there any differences in functionality between this one and dotnet's comment parsing? They appear similiar. |
rossgrambo
approved these changes
Aug 1, 2025
|
@rossgrambo The testcase is generated by copilot. I will make the testcases consistent. |
jimmyca15
reviewed
Aug 5, 2025
jimmyca15
approved these changes
Aug 5, 2025
jimmyca15
reviewed
Aug 6, 2025
jimmyca15
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
671
The reason why we use
stripCommentsinstead ofparsefromjsonc-parseris thatjsonc-parser.parseis too tolerant for syntax error, it will always return a result which will bring behavior change.