-
Notifications
You must be signed in to change notification settings - Fork 3
Support tag filter #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support tag filter #188
Conversation
…avaScriptProvider into zhiyuanliang/select-snapshot
Merge main to preview
…avaScriptProvider into zhiyuanliang/select-snapshot
…re/AppConfiguration-JavaScriptProvider into zhiyuanliang/select-snapshot
…re/AppConfiguration-JavaScriptProvider into zhiyuanliang/tag-filter
…ScriptProvider into zhiyuanliang/select-snapshot
…re/AppConfiguration-JavaScriptProvider into zhiyuanliang/tag-filter
…ScriptProvider into zhiyuanliang/select-snapshot
…re/AppConfiguration-JavaScriptProvider into zhiyuanliang/tag-filter
…ScriptProvider into zhiyuanliang/select-snapshot
…re/AppConfiguration-JavaScriptProvider into zhiyuanliang/tag-filter
…ScriptProvider into zhiyuanliang/tag-filter
|
Could you add more tests? You can refer to .net provider for different tag filter scenarios: https://github.com/Azure/AppConfiguration-DotnetProvider/blob/main/tests/Tests.AzureAppConfiguration/Unit/TagFiltersTests.cs Also, it would be good to include usage example for filtering tags with null value/empty value. This PR description can be modified to fit your PR too: Azure/AppConfiguration-DotnetProvider#637 (comment) |
…ScriptProvider into zhiyuanliang/tag-filter
…ScriptProvider into zhiyuanliang/tag-filter
|
I dont see |
Why this PR?
Extends the existing
SettingSelectortype forAzureAppConfigurationOptions.selectorsandFeatureFlagOptions.selectors.Now, you can pass tag filters that will be used to filter key-values and feature flags. Key-values and feature flags will only be returned if they contain all of the tags and corresponding values passed to the
tagFiltersparameter.Usage
Filtering for tags with empty/null value
You can construct a tag filter string like
"EmptyTag="and"NullTag=\0".