-
Notifications
You must be signed in to change notification settings - Fork 3
Key vault secret refresh #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ScriptProvider into zhiyuanliang/startup-timeout
…re/AppConfiguration-JavaScriptProvider into zhiyuanliang/secret-refresh
…re/AppConfiguration-JavaScriptProvider into zhiyuanliang/secret-refresh
…re/AppConfiguration-JavaScriptProvider into zhiyuanliang/secret-refresh
zhiyuanliang-ms
commented
May 9, 2025
zhiyuanliang-ms
commented
May 9, 2025
…e/AppConfiguration-JavaScriptProvider into zhiyuanliang/secret-refresh
…ScriptProvider into zhiyuanliang/secret-refresh
…ScriptProvider into zhiyuanliang/secret-refresh
…ScriptProvider into zhiyuanliang/secret-refresh
avanigupta
reviewed
Jul 3, 2025
avanigupta
reviewed
Jul 4, 2025
avanigupta
reviewed
Jul 4, 2025
avanigupta
reviewed
Jul 4, 2025
This was referenced Jul 7, 2025
avanigupta
reviewed
Jul 9, 2025
avanigupta
reviewed
Jul 9, 2025
avanigupta
reviewed
Jul 9, 2025
avanigupta
approved these changes
Jul 10, 2025
|
🥳 🎉 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
Usage:
Allow periodic reload of key vault secrets. In this case, even if there is no change on App Configuration key-values. This feature is targeted on the scenario where user is using latest version of a secret. In this case, the key vault reference url will not change, but the secret value will change if user rotates their secret.
Secret cache
Secret with version will be cached after the initial load and whenever a secret reference of that secret is resolved, the value will always be served from the cache.
Secret with no version (which means latest), will be cached after the initial load, and it will be served from cache if the secret refresh interval is configured and not expired. Otherwise, the provider will reload it from the Key Vault.
reference: #249