Skip to content

Conversation

@zhiyuanliang-ms
Copy link
Member

Why this PR?

  • Fix the potential memory leak issue introduced by Promise.race.

  • If srv query failed or timed out, it should not fail the whole provider, instead, it should be a silent error.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/ConfigurationClientManager.ts:152

  • Ensure that the new behavior of swallowing errors in #discoverFallbackClients is covered by tests.
console.warn(`Failed to build fallback clients, ${error.message}`);

@zhiyuanliang-ms zhiyuanliang-ms force-pushed the zhiyuanliang/silent-srvquery-fail branch from 36cf602 to 2cd34f4 Compare February 19, 2025 08:43
@zhiyuanliang-ms zhiyuanliang-ms merged commit c79f4bd into main Feb 19, 2025
6 checks passed
@zhiyuanliang-ms zhiyuanliang-ms deleted the zhiyuanliang/silent-srvquery-fail branch February 19, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants