Skip to content

Conversation

@zhiyuanliang-ms
Copy link
Member

@zhiyuanliang-ms
Copy link
Member Author

This PR need to be merged before stalizing v2

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/AzureAppConfigurationImpl.ts:902

  • The error message on line 902 should be updated to reflect the new behavior of loading all feature flags with no label when no selectors are specified.
return [{ keyFilter: `${featureFlagPrefix}${KeyFilter.Any}`, labelFilter: LabelFilter.Null }];

@zhiyuanliang-ms zhiyuanliang-ms merged commit 5956b72 into preview Feb 10, 2025
4 checks passed
@zhiyuanliang-ms zhiyuanliang-ms deleted the zhiyuanliang/default-ff-selector branch February 10, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants