Skip to content

Update to ETag #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Update to ETag #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b2dc30
update to ETag
zhiyuanliang-ms Oct 17, 2024
97c6453
revert change
zhiyuanliang-ms Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/featureManagement/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ export const FEATURE_FLAGS_KEY_NAME = "feature_flags";
export const TELEMETRY_KEY_NAME = "telemetry";
export const ENABLED_KEY_NAME = "enabled";
export const METADATA_KEY_NAME = "metadata";
export const ETAG_KEY_NAME = "Etag";
export const ETAG_KEY_NAME = "ETag";
export const FEATURE_FLAG_ID_KEY_NAME = "FeatureFlagId";
export const FEATURE_FLAG_REFERENCE_KEY_NAME = "FeatureFlagReference";
8 changes: 4 additions & 4 deletions test/featureFlag.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ const mockedKVs = [{
createMockedFeatureFlag("Beta", { enabled: true }),
createMockedFeatureFlag("Alpha_1", { enabled: true }),
createMockedFeatureFlag("Alpha_2", { enabled: false }),
createMockedFeatureFlag("Telemetry_1", { enabled: true, telemetry: { enabled: true } }, { etag: "Etag"}),
createMockedFeatureFlag("Telemetry_2", { enabled: true, telemetry: { enabled: true } }, { etag: "Etag", label: "Test"})
createMockedFeatureFlag("Telemetry_1", { enabled: true, telemetry: { enabled: true } }, { etag: "ETag"}),
createMockedFeatureFlag("Telemetry_2", { enabled: true, telemetry: { enabled: true } }, { etag: "ETag", label: "Test"})
]);

describe("feature flags", function () {
Expand Down Expand Up @@ -187,7 +187,7 @@ describe("feature flags", function () {
expect(featureFlag.id).equals("Telemetry_1");
expect(featureFlag.telemetry).not.undefined;
expect(featureFlag.telemetry.enabled).equals(true);
expect(featureFlag.telemetry.metadata.Etag).equals("Etag");
expect(featureFlag.telemetry.metadata.ETag).equals("ETag");
expect(featureFlag.telemetry.metadata.FeatureFlagId).equals("krkOsu9dVV9huwbQDPR6gkV_2T0buWxOCS-nNsj5-6g");
expect(featureFlag.telemetry.metadata.FeatureFlagReference).equals(`${createMockedEndpoint()}/kv/.appconfig.featureflag/Telemetry_1`);

Expand All @@ -196,7 +196,7 @@ describe("feature flags", function () {
expect(featureFlag.id).equals("Telemetry_2");
expect(featureFlag.telemetry).not.undefined;
expect(featureFlag.telemetry.enabled).equals(true);
expect(featureFlag.telemetry.metadata.Etag).equals("Etag");
expect(featureFlag.telemetry.metadata.ETag).equals("ETag");
expect(featureFlag.telemetry.metadata.FeatureFlagId).equals("Rc8Am7HIGDT7HC5Ovs3wKN_aGaaK_Uz1mH2e11gaK0o");
expect(featureFlag.telemetry.metadata.FeatureFlagReference).equals(`${createMockedEndpoint()}/kv/.appconfig.featureflag/Telemetry_2?label=Test`);
});
Expand Down
Loading