Use Microsoft feature flag schema and remove use of reflection for json parsing

src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationProvider.cs

@@ -388,7 +388,7 @@ await CallWithRequestTracing(
                             // Invalidate the cached Key Vault secret (if any) for this ConfigurationSetting
                             foreach (IKeyValueAdapter adapter in _options.Adapters)
                             {
-                                adapter.InvalidateCache(change.Current);
+                                adapter.OnChangeDetected(change.Current);
                             }
                         }
                     }
@@ -399,7 +399,7 @@ await CallWithRequestTracing(
                         // Invalidate all the cached KeyVault secrets
                         foreach (IKeyValueAdapter adapter in _options.Adapters)
                         {
-                            adapter.InvalidateCache();
+                            adapter.OnChangeDetected();
                         }
 
                         // Update the next refresh time for all refresh registered settings and feature flags
@@ -734,7 +734,7 @@ await ExecuteWithFailOverPolicyAsync(
                 // Invalidate all the cached KeyVault secrets
                 foreach (IKeyValueAdapter adapter in _options.Adapters)
                 {
-                    adapter.InvalidateCache();
+                    adapter.OnChangeDetected();
                 }
 
                 Dictionary<string, ConfigurationSetting> mappedData = await MapConfigurationSettings(data).ConfigureAwait(false);
@@ -913,6 +913,11 @@ private void SetData(IDictionary<string, string> data)
             // Set the application data for the configuration provider
             Data = data;
 
+            foreach (IKeyValueAdapter adapter in _options.Adapters)
+            {
+                adapter.OnConfigUpdated();
+            }
+
             // Notify that the configuration has been updated
             OnReload();
         }
@@ -1206,11 +1211,21 @@ private void EnsureFeatureManagementVersionInspected()
         {
             if (!_isFeatureManagementVersionInspected)
             {
+                const string FeatureManagementMinimumVersion = "3.2.0";
+
                 _isFeatureManagementVersionInspected = true;
 
                 if (_requestTracingEnabled && _requestTracingOptions != null)
                 {
-                    _requestTracingOptions.FeatureManagementVersion = TracingUtils.GetAssemblyVersion(RequestTracingConstants.FeatureManagementAssemblyName);
+                    string featureManagementVersion = TracingUtils.GetAssemblyVersion(RequestTracingConstants.FeatureManagementAssemblyName);
+
+                    // If the version is less than 3.2.0, log the schema version warning
+                    if (featureManagementVersion != null && Version.Parse(featureManagementVersion) < Version.Parse(FeatureManagementMinimumVersion))
+                    {
+                        _logger.LogWarning(LogHelper.BuildFeatureManagementMicrosoftSchemaVersionWarningMessage());
+                    }
+
+                    _requestTracingOptions.FeatureManagementVersion = featureManagementVersion;
 
                     _requestTracingOptions.FeatureManagementAspNetCoreVersion = TracingUtils.GetAssemblyVersion(RequestTracingConstants.FeatureManagementAspNetCoreAssemblyName);
                 }

src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureKeyVaultReference/AzureKeyVaultKeyValueAdapter.cs

@@ -86,7 +86,7 @@ public bool CanProcess(ConfigurationSetting setting)
             return string.Equals(contentType, KeyVaultConstants.ContentType);
         }
 
-        public void InvalidateCache(ConfigurationSetting setting = null)
+        public void OnChangeDetected(ConfigurationSetting setting = null)
         {
             if (setting == null)
             {
@@ -98,6 +98,11 @@ public void InvalidateCache(ConfigurationSetting setting = null)
             }
         }
 
+        public void OnConfigUpdated()
+        {
+            return;
+        }
+
         public bool NeedsRefresh()
         {
             return _secretProvider.ShouldRefreshKeyVaultSecrets();

src/Microsoft.Extensions.Configuration.AzureAppConfiguration/Constants/ErrorMessages.cs

@@ -7,5 +7,8 @@ internal class ErrorMessages
     {
         public const string RefreshIntervalTooShort = "The refresh interval cannot be less than {0} milliseconds.";
         public const string SecretRefreshIntervalTooShort = "The secret refresh interval cannot be less than {0} milliseconds.";
+        public const string FeatureFlagInvalidJsonProperty = "Invalid property '{0}' for feature flag. Key: '{1}'. Found type: '{2}'. Expected type: '{3}'.";
+        public const string FeatureFlagInvalidFormat = "Invalid json format for feature flag. Key: '{0}'.";
+        public const string InvalidKeyVaultReference = "Invalid Key Vault reference.";
     }
 }

src/Microsoft.Extensions.Configuration.AzureAppConfiguration/Constants/LoggingConstants.cs

@@ -32,5 +32,8 @@ internal class LoggingConstants
         public const string RefreshSkippedNoClientAvailable = "Refresh skipped because no endpoint is accessible.";
         public const string RefreshFailedToGetSettingsFromEndpoint = "Failed to get configuration settings from endpoint";
         public const string FailingOverToEndpoint = "Failing over to endpoint";
+        public const string FeatureManagementMicrosoftSchemaVersionWarning = "Your application may be using an older version of " + 
+            "Microsoft.FeatureManagement library that isn't compatible with Microsoft.Extensions.Configuration.AzureAppConfiguration. Please update " +
+            "the Microsoft.FeatureManagement package to version 3.2.0 or later.";
     }
 }

src/Microsoft.Extensions.Configuration.AzureAppConfiguration/FeatureManagement/ClientFilter.cs

@@ -2,16 +2,13 @@
 // Licensed under the MIT license.
 //
 using System.Text.Json;
-using System.Text.Json.Serialization;
 
 namespace Microsoft.Extensions.Configuration.AzureAppConfiguration.FeatureManagement
 {
     internal class ClientFilter
     {
-        [JsonPropertyName("name")]
         public string Name { get; set; }
 
-        [JsonPropertyName("parameters")]
         public JsonElement Parameters { get; set; }
     }
 }

src/Microsoft.Extensions.Configuration.AzureAppConfiguration/FeatureManagement/FeatureAllocation.cs

@@ -2,28 +2,21 @@
 // Licensed under the MIT license.
 //
 using System.Collections.Generic;
-using System.Text.Json.Serialization;
 
 namespace Microsoft.Extensions.Configuration.AzureAppConfiguration.FeatureManagement
 {
     internal class FeatureAllocation
     {
-        [JsonPropertyName("default_when_disabled")]
         public string DefaultWhenDisabled { get; set; }
 
-        [JsonPropertyName("default_when_enabled")]
         public string DefaultWhenEnabled { get; set; }
 
-        [JsonPropertyName("user")]
         public IEnumerable<FeatureUserAllocation> User { get; set; }
 
-        [JsonPropertyName("group")]
         public IEnumerable<FeatureGroupAllocation> Group { get; set; }
 
-        [JsonPropertyName("percentile")]
         public IEnumerable<FeaturePercentileAllocation> Percentile { get; set; }
 
-        [JsonPropertyName("seed")]
         public string Seed { get; set; }
     }
 }

src/Microsoft.Extensions.Configuration.AzureAppConfiguration/FeatureManagement/FeatureConditions.cs

@@ -2,16 +2,13 @@
 // Licensed under the MIT license.
 //
 using System.Collections.Generic;
-using System.Text.Json.Serialization;
 
 namespace Microsoft.Extensions.Configuration.AzureAppConfiguration.FeatureManagement
 {
     internal class FeatureConditions
     {
-        [JsonPropertyName("client_filters")]
         public List<ClientFilter> ClientFilters { get; set; } = new List<ClientFilter>();
 
-        [JsonPropertyName("requirement_type")]
         public string RequirementType { get; set; }
     }
 }

src/Microsoft.Extensions.Configuration.AzureAppConfiguration/FeatureManagement/FeatureFlag.cs

@@ -2,28 +2,21 @@
 // Licensed under the MIT license.
 //
 using System.Collections.Generic;
-using System.Text.Json.Serialization;
 
 namespace Microsoft.Extensions.Configuration.AzureAppConfiguration.FeatureManagement
 {
     internal class FeatureFlag
     {
-        [JsonPropertyName("id")]
         public string Id { get; set; }
 
-        [JsonPropertyName("enabled")]
         public bool Enabled { get; set; }
 
-        [JsonPropertyName("conditions")]
         public FeatureConditions Conditions { get; set; }
 
-        [JsonPropertyName("variants")]
         public IEnumerable<FeatureVariant> Variants { get; set; }
 
-        [JsonPropertyName("allocation")]
         public FeatureAllocation Allocation { get; set; }
 
-        [JsonPropertyName("telemetry")]
         public FeatureTelemetry Telemetry { get; set; }
     }
 }

src/Microsoft.Extensions.Configuration.AzureAppConfiguration/FeatureManagement/FeatureGroupAllocation.cs

@@ -2,16 +2,13 @@
 // Licensed under the MIT license.
 //
 using System.Collections.Generic;
-using System.Text.Json.Serialization;
 
 namespace Microsoft.Extensions.Configuration.AzureAppConfiguration.FeatureManagement
 {
     internal class FeatureGroupAllocation
     {
-        [JsonPropertyName("variant")]
         public string Variant { get; set; }
 
-        [JsonPropertyName("groups")]
         public IEnumerable<string> Groups { get; set; }
     }
 }

src/Microsoft.Extensions.Configuration.AzureAppConfiguration/FeatureManagement/FeatureManagementConstants.cs

@@ -1,42 +1,48 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 //
+
 namespace Microsoft.Extensions.Configuration.AzureAppConfiguration.FeatureManagement
 {
     internal class FeatureManagementConstants
     {
         public const string FeatureFlagMarker = ".appconfig.featureflag/";
         public const string ContentType = "application/vnd.microsoft.appconfig.ff+json";
-        public const string SectionName = "FeatureManagement";
-        public const string EnabledFor = "EnabledFor";
-        public const string Variants = "Variants";
-        public const string Allocation = "Allocation";
-        public const string User = "User";
-        public const string Group = "Group";
-        public const string Percentile = "Percentile";
-        public const string Telemetry = "Telemetry";
-        public const string Enabled = "Enabled";
-        public const string Metadata = "Metadata";
-        public const string RequirementType = "RequirementType";
-        public const string Name = "Name";
-        public const string Parameters = "Parameters";
-        public const string Variant = "Variant";
-        public const string ConfigurationValue = "ConfigurationValue";
-        public const string ConfigurationReference = "ConfigurationReference";
-        public const string StatusOverride = "StatusOverride";
-        public const string DefaultWhenDisabled = "DefaultWhenDisabled";
-        public const string DefaultWhenEnabled = "DefaultWhenEnabled";
-        public const string Users = "Users";
-        public const string Groups = "Groups";
-        public const string From = "From";
-        public const string To = "To";
-        public const string Seed = "Seed";
+
+        // Feature management section keys
+        public const string FeatureManagementSectionName = "feature_management";
+        public const string FeatureFlagsSectionName = "feature_flags";
+
+        // Feature flag properties
+        public const string Id = "id";
+        public const string Enabled = "enabled";
+        public const string Conditions = "conditions";
+        public const string ClientFilters = "client_filters";
+        public const string Variants = "variants";
+        public const string Allocation = "allocation";
+        public const string UserAllocation = "user";
+        public const string GroupAllocation = "group";
+        public const string PercentileAllocation = "percentile";
+        public const string Telemetry = "telemetry";
+        public const string Metadata = "metadata";
+        public const string RequirementType = "requirement_type";
+        public const string Name = "name";
+        public const string Parameters = "parameters";
+        public const string Variant = "variant";
+        public const string ConfigurationValue = "configuration_value";
+        public const string ConfigurationReference = "configuration_reference";
+        public const string StatusOverride = "status_override";
+        public const string DefaultWhenDisabled = "default_when_disabled";
+        public const string DefaultWhenEnabled = "default_when_enabled";
+        public const string Users = "users";
+        public const string Groups = "groups";
+        public const string From = "from";
+        public const string To = "to";
+        public const string Seed = "seed";
+
+        // Telemetry metadata keys
         public const string ETag = "ETag";
         public const string FeatureFlagId = "FeatureFlagId";
         public const string FeatureFlagReference = "FeatureFlagReference";
-        public const string Status = "Status";
-        public const string AlwaysOnFilter = "AlwaysOn";
-        public const string Conditional = "Conditional";
-        public const string Disabled = "Disabled";
     }
 }