Skip to content

Sample Updates #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Sample Updates #78

wants to merge 3 commits into from

Conversation

@negoe
Copy link
Contributor

@negoe negoe commented Mar 1, 2024 •
edited
Loading

Purpose

  • update the 'user_authorization_agent' to recommended value 'WEBVIEW' and remove 'Default' configuration from config files.
  • Remove ADAL reference from sample code.

Pull Request Type

updates to

  • auth_config_multiple_account.json
  • auth_config_single_account.json
  • AndroidManifest.xml
  • app/build.gradle
  • settings.gradle
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x ] Documentation content changes
[ ] Other... Please describe:

@negoe negoe requested a review from rpdome March 1, 2024 02:06
@negoe negoe changed the title Updated 'Default' recommendation to 'WEBVIEW' in sample Sample Updates Mar 1, 2024
iamgusain
iamgusain reviewed Mar 1, 2024
View reviewed changes
app/build.gradle Outdated
}

allprojects {
/*allprojects {
Copy link
Contributor

@iamgusain iamgusain Mar 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncomment? or remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rpdome rpdome Awaiting requested review from rpdome

1 more reviewer

@iamgusain iamgusain iamgusain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@negoe @iamgusain