This repository has been archived by the owner. It is now read-only.
add qs for new code patterns #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameerag
reviewed
Apr 14, 2019
sameerag
approved these changes
Apr 15, 2019
navyasric
suggested changes
Apr 15, 2019
JavaScriptSPA/index.html
Outdated
| auth: { | ||
| clientId: applicationConfig.clientID, | ||
| authority: applicationConfig.authority, | ||
| validateAuthority: true |
Contributor
There was a problem hiding this comment.
validateAuthority is by default true. Can we remove the explicitly setting if not needed again? This will be one extra option to explain in the quickstart.
DarylThayil
force-pushed
the
qs
branch
3 times, most recently
from
e79d834 to
93d05ef
Compare
sameerag
reviewed
Apr 22, 2019
DarylThayil
force-pushed
the
qs
branch
5 times, most recently
from
20fa569 to
b8694b7
Compare
DarylThayil
force-pushed
the
qs
branch
2 times, most recently
from
af4ce24 to
8e63208
Compare
navyasric
approved these changes
Apr 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update quickstart for new code patterns
DO NOT MERGE- pending release of msal.js 1.0.0-preview version to NPM