-
Notifications
You must be signed in to change notification settings - Fork 281
Added isort, ran isort on all files #1351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added isort, ran isort on all files #1351
Conversation
|
The CI has failed with the following traceback: Let me know if you'd like me to take a closer look and figure out what's going on. |
|
@drvinceknight I have fixed the issues. 😄 |
gaffney2010
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice change!
|
This is great! It would be nice to add a check to the CI so that imports don't get "unsorted" in the future. In https://github.com/Axelrod-Python/Axelrod/blob/master/.github/workflows/config.yml could you add: |
Done! 😄 |
|
Fantastic, thanks for the contribution @akash-suresh 👍 |
Resolves #1326
@drvinceknight I have added an
isortconfig, and runisortover all the files.Let me know if there are any modifications needed in the
.isort.cfgfile.