Skip to content

Unify Posts and Pages Endpoints for Custom Post Type Support #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 25, 2025
Merged

Unify Posts and Pages Endpoints for Custom Post Type Support #915

merged 12 commits into from
Sep 25, 2025

Conversation

oguzkocer
Copy link
Contributor

@oguzkocer oguzkocer commented Sep 24, 2025 •
edited
Loading

Summary

Consolidates the separate /posts and /pages endpoints into a unified /posts endpoint that accepts a PostEndpointType parameter, enabling support for custom post types while maintaining backward compatibility for existing functionality.

Breaking Changes

  • API Changes: Posts methods now require PostEndpointType parameter (.posts, .pages, or .custom(String))
  • Type Consolidation: SparsePost/SparsePage → SparseAnyPost, PostWithEditContext/PageWithEditContext → AnyPostWithEditContext
  • Removed Types: Eliminated separate page-specific types and endpoints

Key Changes

  • Rust: Unified SparseAnyPost type with #[WpContextualOption] for page-specific fields
  • Kotlin/Swift: Updated method signatures and removed legacy page endpoints
  • Runtime Flexibility: Trade compile-time type safety for runtime post type flexibility
  • Custom Post Types: Foundation for supporting WordPress plugins that define custom post types

Migration

// Before
client.pages().list_with_edit_context(params)

// After
client.posts().list_with_edit_context(PostEndpointType::Pages, params)

@oguzkocer oguzkocer added this to the 0.2 milestone Sep 24, 2025
@oguzkocer oguzkocer added the Rust label Sep 24, 2025
@oguzkocer oguzkocer changed the title POC: Any post Unify Posts and Pages Endpoints for Custom Post Type Support Sep 25, 2025
@jkmassel jkmassel marked this pull request as ready for review September 25, 2025 17:48
jkmassel
jkmassel approved these changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@jkmassel jkmassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the Swift sample app and it works great

@oguzkocer oguzkocer enabled auto-merge (squash) September 25, 2025 17:54
@oguzkocer oguzkocer merged commit cefd079 into trunk Sep 25, 2025
22 checks passed
@oguzkocer oguzkocer deleted the any-post branch September 25, 2025 18:17
oguzkocer added a commit that referenced this pull request Sep 26, 2025
@oguzkocer
Complete Swift implementation for unified terms endpoint
34c3728 
Update Swift wrapper and example app to use the new unified terms endpoint
with TermEndpointType parameter, following the same pattern as the posts
unification in PR #915. This enables custom taxonomy support while maintaining
backward compatibility for existing categories and tags functionality.

Changes:
- Update WordPressAPI.swift to use unified terms endpoint
- Update Pagination.swift with TypedPaginationAwareExecutor for terms
- Add categories and tags examples to Swift demo app
- Add AnyTermWithEditContext support in ListViewData
- Fix CancellationTests to use new posts API signature
oguzkocer added a commit that referenced this pull request Sep 26, 2025
@oguzkocer
Complete Swift implementation for unified terms endpoint
f1a1767 
Update Swift wrapper and example app to use the new unified terms endpoint
with TermEndpointType parameter, following the same pattern as the posts
unification in PR #915. This enables custom taxonomy support while maintaining
backward compatibility for existing categories and tags functionality.

Changes:
- Update WordPressAPI.swift to use unified terms endpoint
- Update Pagination.swift with TypedPaginationAwareExecutor for terms
- Add categories and tags examples to Swift demo app
- Add AnyTermWithEditContext support in ListViewData
- Fix CancellationTests to use new posts API signature
oguzkocer added a commit that referenced this pull request Sep 26, 2025
@oguzkocer
Complete Swift implementation for unified terms endpoint
e55f139 
Update Swift wrapper and example app to use the new unified terms endpoint
with TermEndpointType parameter, following the same pattern as the posts
unification in PR #915. This enables custom taxonomy support while maintaining
backward compatibility for existing categories and tags functionality.

Changes:
- Update WordPressAPI.swift to use unified terms endpoint
- Update Pagination.swift with TypedPaginationAwareExecutor for terms
- Add categories and tags examples to Swift demo app
- Add AnyTermWithEditContext support in ListViewData
- Fix CancellationTests to use new posts API signature
oguzkocer added a commit that referenced this pull request Sep 26, 2025
@oguzkocer
Complete Swift implementation for unified terms endpoint
b984cb5 
Update Swift wrapper to use the new unified terms endpoint
with TermEndpointType parameter, following the same pattern as the posts
unification in PR #915. This enables custom taxonomy support while maintaining
backward compatibility for existing categories and tags functionality.

Changes:
- Update WordPressAPI.swift to use unified terms endpoint
- Update Pagination.swift with TypedPaginationAwareExecutor for terms
- Add AnyTermWithEditContext support in ListViewData
- Fix CancellationTests to use new posts API signature
oguzkocer added a commit that referenced this pull request Sep 26, 2025
@oguzkocer
Unify Categories and Tags Endpoints for Custom Term Type Support (#921)
e28f800 
* Unify categories and tags endpoints into terms endpoint

Consolidate separate categories and tags REST API endpoints into a unified
terms endpoint to reduce code duplication and improve maintainability.
The unified approach uses TermEndpointType to distinguish between different
taxonomy types while sharing common functionality.

Changes:
- Replace CategoryId and TagId with unified TermId type
- Consolidate CategoryCreateParams/TagCreateParams into TermCreateParams
- Consolidate CategoryListParams/TagListParams into TermListParams
- Consolidate CategoryUpdateParams/TagUpdateParams into TermUpdateParams
- Add TermEndpointType enum to specify taxonomy type (Categories/Tags)
- Update API client to use unified terms() endpoint methods
- Update all integration tests to use new unified terms API
- Update Swift and Kotlin bindings to export unified types
- Remove legacy categories_endpoint and tags_endpoint modules

* Complete Swift implementation for unified terms endpoint

Update Swift wrapper to use the new unified terms endpoint
with TermEndpointType parameter, following the same pattern as the posts
unification in PR #915. This enables custom taxonomy support while maintaining
backward compatibility for existing categories and tags functionality.

Changes:
- Update WordPressAPI.swift to use unified terms endpoint
- Update Pagination.swift with TypedPaginationAwareExecutor for terms
- Add AnyTermWithEditContext support in ListViewData
- Fix CancellationTests to use new posts API signature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkmassel jkmassel jkmassel approved these changes

Assignees
No one assigned
Labels
Endpoint Kotlin Rust Swift
Projects
None yet
Milestone
0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@oguzkocer @jkmassel