Skip to content

Conversation

@gavande1
Copy link
Contributor

@gavande1 gavande1 commented Nov 7, 2025

Related issues

Proposed Changes

  • Update Studio protocol from from wpcom-local-dev to wp-studio to the existing app manifest

Testing Instructions

Taken from #1969, Props to @bcotrim

  1. Download the signed .appx file from the CI build artifacts for this PR (https://buildkite.com/automattic/studio/builds/9170/steps/canvas?jid=019aa14c-6f7d-4be5-bbac-d950b13e7e91)
  2. Install the .appx on a Windows machine (right click -> Install)
  3. Open Studio and click the "Login" button in the top right
  4. Authenticate in the browser when redirected to WordPress.com
  5. After approving, verify the browser shows "Authorized. You can now open Studio and close this window."
  6. Verify Studio successfully logs you in and displays your account information

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@gavande1 gavande1 changed the title Update protocol handler name in appx packaging script from 'wpcom-loc… Studio: Update Studio scheme protocol handler to AppxManifest for Windows Nov 7, 2025
@gavande1
Copy link
Contributor Author

gavande1 commented Nov 7, 2025

This needs to be deployed after #2029 is deployed.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

📊 Performance Test Results

Comparing 5acc4ca vs trunk

site-editor

Metric trunk 5acc4ca Diff Change
load 17114.00 ms 14498.00 ms -2616.00 ms 🟢 -15.3%

site-startup

Metric trunk 5acc4ca Diff Change
siteCreation 27589.00 ms 27352.00 ms -237.00 ms 🟢 -0.9%
siteStartup 9028.00 ms 11009.00 ms +1981.00 ms 🔴 21.9%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@gavande1 gavande1 self-assigned this Nov 7, 2025
@gavande1 gavande1 requested a review from bcotrim November 11, 2025 13:13
@gavande1 gavande1 force-pushed the STU-936-add-protocol-handler-manifest branch from 6828938 to 9af92b4 Compare November 18, 2025 09:26
@gavande1 gavande1 force-pushed the STU-936-add-protocol-handler-manifest branch from 9af92b4 to 7261a2a Compare November 20, 2025 12:45
@gavande1 gavande1 marked this pull request as ready for review November 20, 2025 12:46
@gavande1 gavande1 requested a review from a team November 20, 2025 12:46
@gcsecsey
Copy link
Contributor

In #2018 we made builds on PRs optional, so I started the Windows builds on Buildkite for this PR. ⌛

@gavande1
Copy link
Contributor Author

Thanks @gcsecsey for running the Windows build.

@gavande1 gavande1 removed the request for review from bcotrim November 20, 2025 13:26
Copy link
Contributor

@gcsecsey gcsecsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the handler @gavande1! This works well for me on Windows. 👍

CleanShot.2025-11-20.at.13.32.26.mp4

@gavande1 gavande1 merged commit ad8e880 into trunk Nov 20, 2025
11 checks passed
@gavande1 gavande1 deleted the STU-936-add-protocol-handler-manifest branch November 20, 2025 13:34
@gavande1
Copy link
Contributor Author

I am deploying this for beta release. Feel free to test it again for edge cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants