Skip to content

Conversation

@gcsecsey
Copy link
Contributor

@gcsecsey gcsecsey commented Nov 7, 2025

Related issues

Fixes STU-711

Proposed Changes

  • Remove pullStates and pushStates React state from SyncSitesProvider
  • Implement syncOperations Redux slice

Testing Instructions

  • Run npm start
  • Go to the Sync tab
  • Connect a site
  • Pull changes from the site and check that there are no regressions
  • Push changes to the site and check that there are no regressions

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@gcsecsey gcsecsey requested a review from a team November 7, 2025 12:12
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

📊 Performance Test Results

Comparing 7f8a9bb vs trunk

site-editor

Metric trunk 7f8a9bb Diff Change
load 15854.00 ms 16703.00 ms +849.00 ms 🔴 5.4%

site-startup

Metric trunk 7f8a9bb Diff Change
siteCreation 22219.00 ms 22199.00 ms -20.00 ms 🟢 -0.1%
siteStartup 6945.00 ms 9029.00 ms +2084.00 ms 🔴 30.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

Copy link
Contributor

@nightnei nightnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Push: it seems it stucks at "Creating backup..." step. Tried a few times and also tried in trunk - worked quickly for me.

Pull: not related to the changes, since I reproduce the error in trunk too, but if you are working there - take a look please at this error when pull is finished, maybe it's a quck win:

Screenshot 2025-11-18 at 19 07 39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants