Fixed context.restore when there is no stack of saves #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context.restore on a freshly resized canvas broke drawing to the canvas, it seems cairo was always saving and restoring, even when there was no need. This has fixed issues using vanilla flot 0.8.1 :)
Collaborator
|
@rvagg mind taking a look at this? |
Contributor
|
code looks fine, no idea about the logic, @GothAck is it possible to include one or two minor tests for this to (1) prove the problem exists and (2) protect against future regressions? |
|
Is this still an issue? it seems to be happening on 1.2.1 |
Collaborator
|
@olivierrr What exactly is the problem that is occurring, would it be possible to write a test case for this? |
Merged
Collaborator
|
Fixed by #810 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context.restore on a freshly resized canvas broke drawing to the canvas, it seems cairo was always saving and restoring, even when there was no need. This has fixed issues using vanilla flot 0.8.1 :)