Skip to content

Conversation

@LinusU
Copy link
Collaborator

@LinusU LinusU commented Jan 14, 2019

I noticed that some of my VSCode configs were being published along with the module 😂

This PR changes to an explicit list to things to include, instead of an ignore-file.

This is the difference in published files:

--- a	2019-01-14 18:31:52.000000000 +0000
+++ b	2019-01-14 18:32:04.000000000 +0000
@@ -1,15 +1,9 @@
 package.json
-.travis.yml
-appveyor.yml
 binding.gyp
 browser.js
 CHANGELOG.md
 index.js
 Readme.md
-.github/ISSUE_TEMPLATE.md
-.github/PULL_REQUEST_TEMPLATE.md
-.vscode/c_cpp_properties.json
-.vscode/settings.json
 lib/bindings.js
 lib/canvas.js
 lib/context2d.js

ping @zbjornson, @chearon do you think it's a good approach? ☺️

Copy link
Collaborator

@zbjornson zbjornson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for some reason I was just looking at this this weekend!

@chearon
Copy link
Collaborator

chearon commented Jan 14, 2019

Sure, does this mean we could/should get rid of npmignore?

@LinusU
Copy link
Collaborator Author

LinusU commented Jan 15, 2019

[...] get rid of npmignore?

yeah, it's removed in this PR ☺️

@LinusU LinusU merged commit b968c8a into Automattic:master Jan 15, 2019
@LinusU LinusU deleted the npm-files branch January 15, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants