Clean up #includes #1341
Merged
Clean up #includes #1341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Looks like I'm missing a header for GCC -- will fix when I fix the conflicts after #1340 goes in. |
zbjornson
force-pushed
the
zb/codecleanup
branch
from
aefeff7 to
c078505
Compare
None of these are necessary anymore
zbjornson
force-pushed
the
zb/codecleanup
branch
from
70b8c42 to
7d9db83
Compare
Collaborator
Author
|
Ready to go! I tacked on a few more small fixups. Tested with GCC 4.8.5, GCC 8.1.0, MSVC 2015 and MSVC 2017. Can someone please check with Apple Clang? |
Collaborator
|
I'll test with Apple Clang today 🙌 edit: it works, great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been bugging me for ages. Each header can now stand alone and has no
using namespaces.I don't think this creates any conflicts with open PRs that are close to landing, except my #1340.
(Can we remove the comments at the top of the files from 2010 with the file name and copyright notice?)