Catch font errors #1328
Merged
Catch font errors #1328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbjornson
reviewed
Dec 13, 2018
src/CanvasRenderingContext2d.cc
Outdated
| try_catch.ReThrow(); | ||
| return; | ||
| } | ||
| Local<Object> font = maybeFont.ToLocalChecked(); |
Collaborator
There was a problem hiding this comment.
Thanks for the fast fix :).
A bit simpler: you can explicitly check if the MaybeLocal is empty with something like:
MaybeLocal<Object> mlfont = Nan::To<Object>(parsed);
if (mlfont.IsEmpty()) return;
Local<Object> font = mlfont.ToLocalChecked();The error will still be thrown appropriately when the handle is empty.
Contributor
Author
There was a problem hiding this comment.
Done. Is there a need to test if mparsed is empty (can parseFont itself throw an error)?
Collaborator
There was a problem hiding this comment.
Technically I'm not sure if there's any v8 operation that returns a MaybeLocal that is guaranteed not to fail. (It seems it would return a Local instead.) I'm not sure how unwise it is to assume simple operations don't fail. Having it doesn't hurt.
zbjornson
approved these changes
Dec 13, 2018
This was referenced Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1327