-
Notifications
You must be signed in to change notification settings - Fork 842
CI: Run Phan against WooCommerce 7.0 stubs #46036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
.github/workflows/linting.yml
Outdated
| WOO_VERSION: 7 | ||
| run: | | ||
| composer update --prefer-lowest php-stubs/wordpress-stubs php-stubs/wordpress-tests-stubs | ||
| # We can't directly downgrade Woo stubs with `update` due to existing constraints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we if we change the constraint in composer.json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean in trunk like we do with WP stubs? We could; I personally lean toward keeping constraints tighter in there, but right now it's >=8.7, so if that's your preference I can do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give it a go: e53acbb
anomiex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and I see the downgrading in the logs for the second Phan run.
Closes MONOREP-245
This PR runs Phan against WooCommerce 7.0 stubs. Supersedes #45986.
Proposed changes:
We've had a few cases where Jetpack releases have unleashed some fatals because an assumption that users ran fairly recent WooCommerce versions:
If there's a need we could consider generating new
woocommerce-internalstubs, but that'd be for another PR should we want.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Is CI happy?