Skip to content

Conversation

@sirreal
Copy link
Member

@sirreal sirreal commented Nov 18, 2025

Proposed changes:

Fixes the syntaxhighlighter/code transforms so that the code and some attributes are better preserved.

Notice that before line breaks were not handled correctly:

sh-xform-before

After, the block survives a round-trip transform:

sh-xform-after

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Does this pull request change what data or activity we track or use?

no

Testing instructions:

Create a code block, use interesting HTML special syntax and line breaks.
Confirm that the block and its content survive a round trip, transforming to syntaxhighlighter/code and back.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the code-block/add-syntax-highlighter-xform branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin code-block/add-syntax-highlighter-xform

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control
Copy link

jp-launch-control bot commented Nov 18, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report

@sirreal sirreal force-pushed the code-block/add-syntax-highlighter-xform branch from d31cd5e to 5dde076 Compare November 19, 2025 10:52
@sirreal sirreal added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Nov 19, 2025
@sirreal sirreal marked this pull request as ready for review November 19, 2025 12:07
@sirreal sirreal requested a review from a team November 19, 2025 12:07
@sirreal sirreal merged commit 3aac27b into trunk Nov 19, 2025
70 checks passed
@sirreal sirreal deleted the code-block/add-syntax-highlighter-xform branch November 19, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants