Skip to content

Conversation

@haqadn
Copy link
Contributor

@haqadn haqadn commented Nov 18, 2025

Proposed changes:

  • Uninstall was calling wp_clear_scheduled_hook with the wrong name. Update it to the correct value: jetpack_boost_general_cleanup.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

#45920 (review)

Does this pull request change what data or activity we track or use?

None

Testing instructions:

None

@haqadn haqadn requested review from a team and manzoorwanijk November 18, 2025 18:24
@haqadn haqadn self-assigned this Nov 18, 2025
@haqadn haqadn added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. labels Nov 18, 2025
@github-actions github-actions bot added the [Plugin] Boost A feature to speed up the site and improve performance. label Nov 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Boost plugin:

  • Next scheduled release: November 26, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control
Copy link

jp-launch-control bot commented Nov 18, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@haqadn haqadn merged commit e547537 into trunk Nov 20, 2025
74 checks passed
@haqadn haqadn deleted the fix/transient-cleanup branch November 20, 2025 17:30
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Nov 20, 2025
@github-actions github-actions bot added this to the boost/4.6.0 milestone Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Boost A feature to speed up the site and improve performance. [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants