Skip to content

Conversation

@lezama
Copy link
Contributor

@lezama lezama commented Nov 16, 2025

Proposed changes:

  • Refactors the Forms dashboard layout structure by introducing a new Page component system with reusable primitives (Header, Stack, NavigableRegion,
    SidebarToggleSlot)
  • Simplifies DataViews footer positioning by removing custom positioning logic and using default sticky behavior
  • Wraps the dashboard in SlotFillProvider to enable slot/fill pattern for future extensibility
  • Adjusts header offset calculation for mobile viewports to prevent layout issues
  • Fixes viewport check logic to properly detect mobile/desktop breakpoints
  • Improves overall code maintainability by componentizing layout concerns

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Desktop Testing

  • Verify the dashboard layout renders correctly
  • Scroll down to verify the DataViews footer sticks to the bottom of the viewport
  • Click on a response to open the sidebar inspector
  • Verify the layout remains stable when opening/closing the inspector

Mobile Testing

  • Resize your browser to mobile viewport (< 782px width) or test on actual mobile device
  • Verify the header displays correctly without overlapping content
  • Verify the DataViews footer positioning is correct
  • Verify scrolling behavior works smoothly
  • Test opening/closing the inspector sidebar

Multi-select Testing

  • Select multiple responses using checkboxes
  • Verify the bulk actions UI displays correctly

Expected Results

  • No visual regressions compared to trunk
  • Layout should be responsive and stable across viewports
  • Footer should properly stick to viewport bottom
  • No console errors
  • Header spacing should be consistent on mobile

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added [Package] Forms Docs [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Nov 16, 2025
@lezama lezama force-pushed the refactor/forms-dashboard-layout-page-components branch from 6ec9f57 to 8f7ea2f Compare November 17, 2025 14:40
@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the refactor/forms-dashboard-layout-page-components branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack refactor/forms-dashboard-layout-page-components

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@jp-launch-control
Copy link

jp-launch-control bot commented Nov 17, 2025

Code Coverage Summary

Coverage changed in 4 files.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/dashboard/components/response-actions/index.tsx 0/51 (0.00%) 0.00% 2 ❤️‍🩹
projects/packages/forms/src/dashboard/components/export-responses/button.tsx 0/8 (0.00%) 0.00% 1 ❤️‍🩹
projects/packages/forms/src/dashboard/components/response-navigation/index.tsx 0/4 (0.00%) 0.00% 1 ❤️‍🩹
projects/packages/forms/src/dashboard/components/layout/index.tsx 0/9 (0.00%) 0.00% -5 💚

13 files are newly checked for coverage. Only the first 5 are listed here.

File Coverage
projects/packages/forms/src/dashboard/components/inspector/body.tsx 0/94 (0.00%) 💔
projects/packages/forms/src/dashboard/components/inspector/mobile.tsx 0/11 (0.00%) 💔
projects/packages/forms/src/dashboard/components/inspector/single.tsx 0/44 (0.00%) 💔
projects/packages/forms/src/dashboard/components/page/header.tsx 0/1 (0.00%) 💔
projects/packages/forms/src/dashboard/components/page/index.tsx 0/3 (0.00%) 💔

Full summary · PHP report · JS report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

@lezama lezama merged commit fbbea63 into trunk Nov 17, 2025
68 of 69 checks passed
@lezama lezama deleted the refactor/forms-dashboard-layout-page-components branch November 17, 2025 21:34
@github-actions github-actions bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants