-
Notifications
You must be signed in to change notification settings - Fork 841
Forms: Update unread indicator #45950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Updated the inbox unread indicator with improved styling, including background color, size, and positioning. Modified IP address rendering to use wrapperUnread for better handling of unread status.
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the unread indicator design in the Forms dashboard to better align with the intended design. The indicator changes from a text-based bullet point to a solid circular badge positioned over the avatar.
- Redesigned unread indicator as a circular badge with background color and border
- Applied unread styling (bold text) to the IP Address field for consistency
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| projects/packages/forms/src/dashboard/inbox/style.scss | Updated CSS for unread indicator to render as a solid circular badge with absolute positioning over the avatar |
| projects/packages/forms/src/dashboard/inbox/dataviews/index.js | Applied wrapperUnread to IP Address field to make it bold when unread, consistent with other fields |
| projects/packages/forms/changelog/update-forms-move-unread-indicator | Added changelog entry documenting the design update |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| color: #d63638; | ||
| background-color: #d63638; | ||
| overflow: hidden; | ||
| font-size: 8px; |
Copilot
AI
Nov 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CSS properties font-size and color are no longer needed since the indicator now uses background-color with overflow: hidden to create a solid colored dot. The text content (●) inside the span is hidden and these font-related properties serve no purpose. Consider removing these redundant properties to improve code clarity.
| color: #d63638; | |
| background-color: #d63638; | |
| overflow: hidden; | |
| font-size: 8px; | |
| background-color: #d63638; | |
| overflow: hidden; |
projects/packages/forms/changelog/update-forms-move-unread-indicator
Outdated
Show resolved
Hide resolved
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
|
A bit unclear what should happen when we then allow hiding the avatar (#45692)
Not a blocker necessarily now, but would make next steps harder. It's a bit under convo still (p1761944997981159-slack-C05QAFZSFTL) We're also discussing (internal ref pgzWbf-3n3-p2) about how to implement & how unread notifications should look like, so perhaps it's better to change all at once once we're more settled on both approaches? Mainly so that we don't change it to users back-and-forth too many times in. |
|
It would be better to wait a bit on this one, until we align internally. 🙏 |
…icator Co-authored-by: Copilot <[email protected]>

This PR updates the unread indicator to be more like it was designed.
Before:

After:

Proposed changes:
Other information:
Jetpack product discussion
See p1HpG7-xmp-p2
Does this pull request change what data or activity we track or use?
no
Testing instructions:
Visit the dashboard. Mark something as unread.
Notice the new design.