Skip to content

Conversation

@enejb
Copy link
Member

@enejb enejb commented Nov 15, 2025

This PR updates the unread indicator to be more like it was designed.

Before:
Screenshot 2025-11-14 at 5 08 26 PM

After:
Screenshot 2025-11-14 at 4 56 50 PM

Proposed changes:

  • Update the design of the Unread indicator to be more like designed/

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

See p1HpG7-xmp-p2

Does this pull request change what data or activity we track or use?

no

Testing instructions:

Visit the dashboard. Mark something as unread.
Notice the new design.

Updated the inbox unread indicator with improved styling, including background color, size, and positioning. Modified IP address rendering to use wrapperUnread for better handling of unread status.
@enejb enejb requested review from a team, Copilot and ilonagl November 15, 2025 01:10
@enejb enejb added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Package] Forms labels Nov 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-move-unread-indicator branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/forms-move-unread-indicator

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copilot finished reviewing on behalf of enejb November 15, 2025 01:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the unread indicator design in the Forms dashboard to better align with the intended design. The indicator changes from a text-based bullet point to a solid circular badge positioned over the avatar.

  • Redesigned unread indicator as a circular badge with background color and border
  • Applied unread styling (bold text) to the IP Address field for consistency

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
projects/packages/forms/src/dashboard/inbox/style.scss Updated CSS for unread indicator to render as a solid circular badge with absolute positioning over the avatar
projects/packages/forms/src/dashboard/inbox/dataviews/index.js Applied wrapperUnread to IP Address field to make it bold when unread, consistent with other fields
projects/packages/forms/changelog/update-forms-move-unread-indicator Added changelog entry documenting the design update

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 132 to 135
color: #d63638;
background-color: #d63638;
overflow: hidden;
font-size: 8px;
Copy link

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS properties font-size and color are no longer needed since the indicator now uses background-color with overflow: hidden to create a solid colored dot. The text content (●) inside the span is hidden and these font-related properties serve no purpose. Consider removing these redundant properties to improve code clarity.

Suggested change
color: #d63638;
background-color: #d63638;
overflow: hidden;
font-size: 8px;
background-color: #d63638;
overflow: hidden;

Copilot uses AI. Check for mistakes.
@jp-launch-control
Copy link

jp-launch-control bot commented Nov 15, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@simison
Copy link
Member

simison commented Nov 17, 2025

A bit unclear what should happen when we then allow hiding the avatar (#45692)

image

Not a blocker necessarily now, but would make next steps harder. It's a bit under convo still (p1761944997981159-slack-C05QAFZSFTL)

We're also discussing (internal ref pgzWbf-3n3-p2) about how to implement & how unread notifications should look like, so perhaps it's better to change all at once once we're more settled on both approaches? Mainly so that we don't change it to users back-and-forth too many times in.

@ilonagl
Copy link

ilonagl commented Nov 17, 2025

It would be better to wait a bit on this one, until we align internally. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Contact Form [Package] Forms [Status] Needs Review This PR is ready for review. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants