Skip to content

Subscriptions: do not display error message on private sites #45941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
+6 −4
Open

Subscriptions: do not display error message on private sites #45941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/update-newsletter-panel-private-sites
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: other

Subscriptions: do not display warning in the Newsletter panel when a WordPress.com site is marked as private.
6 changes: 2 additions & 4 deletions projects/plugins/jetpack/extensions/blocks/subscriptions/panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { getRedirectUrl } from '@automattic/jetpack-components';
import {
getSiteFragment,
isComingSoon,
isPrivateSite,
useAnalytics,
} from '@automattic/jetpack-shared-extension-utils';
import { JetpackEditorPanelLogo } from '@automattic/jetpack-shared-extension-utils/components';
Expand Down Expand Up @@ -194,9 +193,8 @@ export default function SubscribePanels() {
return null;
}

// Subscriptions will not be triggered on private sites ( on WordPress.com simple and WoA ),
// nor on sites that have not been launched yet.
if ( isPrivateSite() || isComingSoon() ) {
// Subscriptions will not be triggered on WordPress.com sites that have not been launched yet.
if ( isComingSoon() ) {
return <NewsletterDisabledPanels />;
}

Expand Down
Loading