Skip to content

fix: pass sorting status to SortIndicator #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2023
Merged

fix: pass sorting status to SortIndicator #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
469419d
fix: pass sorting status to SortIndicator
tonnyskk Mar 12, 2023
d6a7150
chore: bump version to 1.13.3
tonnyskk Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## NEXT VERSION

## v1.13.3 (2023-03-13)

- fix: pass extra sorting props to custom SortIndicator component

## v1.13.2 (2022-05-14)

- fix: error imported by optimization render task
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-base-table",
"version": "1.13.2",
"version": "1.13.3",
"description": "a react table component to display large data set with high performance and flexibility",
"main": "lib/index.js",
"module": "es/index.js",
Expand Down
1 change: 1 addition & 0 deletions src/BaseTable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,7 @@ class BaseTable extends React.PureComponent {
{cell}
{column.sortable && (
<SortIndicator
sorting={sorting}
sortOrder={sortOrder}
className={cn(this._prefixClass('sort-indicator'), {
[this._prefixClass('sort-indicator--descending')]: sortOrder === SortOrder.DESC,
Expand Down