A combination of a number of commits to tidy up the PR backlog #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edkilday
changed the title
Source/buildimplementationjs.go
Outdated
| returnValue := "" | ||
| if param.ParamType == "class" { | ||
| returnValue = fmt.Sprintf("createV8Instance(objectCreator, param%s, %s_MapClassIdToInjectionClassType(param%s->%s()))", param.ParamName, subComponent.NameSpace, param.ParamName, subComponent.Global.ClassTypeIdMethod) | ||
| returnValue = fmt.Sprintf("param%s?createV8Instance(objectCreator, param%s, %s_MapClassIdToInjectionClassType(param%s->%s())):v8::Local<v8::Object>()", param.ParamName, param.ParamName, subComponent.NameSpace, param.ParamName, subComponent.Global.ClassTypeIdMethod) // Very bad |
There was a problem hiding this comment.
yes, this is a huge mouth full and hard to read. but you are not introducing that pattern here.
I would even go as far as to remove the comment, or atleast say in the comment that you are not happy with the long ternary statement itself.
Would need some refactoring to get rid of...
There was a problem hiding this comment.
I think I left that in accidentally because I did something 'very bad', changed it and then left the comment. I'll get it removed
There was a problem hiding this comment.
No its that line. It is just hard to read. I'll do something about that.
martinweismann
approved these changes
Sep 27, 2023
edkilday
commented
Sep 27, 2023
| " retVal = createV8Instance(objectCreator, param%s, %s_MapClassIdToInjectionClassType(param%s->%s()));", | ||
| param.ParamName, subComponent.NameSpace, param.ParamName, subComponent.Global.ClassTypeIdMethod) | ||
| writer.Writeln("}") | ||
| } else if param.ParamType == "enum" { |
There was a problem hiding this comment.
Ahh. I already changed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format go files using gofmt
Reintroduce case insensitive method and property names in the javascript bindings
Use method delarations instead of arrow function in the generated typescript
Support optionalclass return values in the javascript bindings
Don't prepend c++ error messages with "Error: "