Skip to content

Implement sin, cos, tan and sincos for Math #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 49 commits into from
Sep 15, 2019
Merged

Implement sin, cos, tan and sincos for Math #806

merged 49 commits into from
Sep 15, 2019

Conversation

MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Sep 1, 2019 •
edited
Loading

DONE

  • More tests
  • Math.sincos
  • More optimizations

finally close #58

@MaxGraey
Copy link
Member Author

MaxGraey commented Sep 1, 2019 •
edited
Loading

It seems I should rewrite this part with fast path to classical Cody Waite scheme 😒

EDIT
Done

@MaxGraey MaxGraey changed the title [WIP] Implement Math.sin, Math.cos and Math.tan Implement Math.sin, Math.cos and Math.tan Sep 7, 2019
@MaxGraey MaxGraey changed the title Implement Math.sin, Math.cos and Math.tan Implement Math.sin, Math.cos, Math.tan and Math.sincos Sep 7, 2019
@MaxGraey MaxGraey changed the title Implement Math.sin, Math.cos, Math.tan and Math.sincos Implement sin, cos, tan and sincos for Math Sep 7, 2019
@MaxGraey MaxGraey requested a review from dcodeIO September 7, 2019 18:31
@dcodeIO dcodeIO merged commit 11ab3a6 into AssemblyScript:master Sep 15, 2019
@dcodeIO
Copy link
Member

dcodeIO commented Sep 15, 2019

Great work! :)

@MaxGraey MaxGraey deleted the math-sincos branch September 15, 2019 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO Awaiting requested review from dcodeIO

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement NativeMath/NativeMathf.sin/cos/tan
2 participants
@MaxGraey @dcodeIO