Skip to content

Speedup tokenizer & parser #2161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 134 commits into from

Conversation

MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Dec 2, 2021

Optimize tokenizer and parser.

Parser stage now faster by 14-15%.

Also tokenize ??, ??=, ||=, &&=

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@MaxGraey MaxGraey marked this pull request as ready for review December 7, 2021 10:30
@MaxGraey MaxGraey requested a review from dcodeIO December 7, 2021 10:30
Copy link
Member

@dcodeIO dcodeIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I am happy with improving this and speeding it up, but I must admit that I am getting a little lost. Commented on a few things already, but I'd like to kindly ask to split this PR :)

@dcodeIO
Copy link
Member

dcodeIO commented Jan 15, 2022

You know what, if you say this is good, let's just do it this way :)

Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Nov 11, 2023
Copy link

This PR has been automatically closed due to lack of recent activity, but feel free to reopen it as long as you merge in the main branch afterwards.

@github-actions github-actions bot closed this Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants