-
-
Notifications
You must be signed in to change notification settings - Fork 669
feat: Add __getFunction method for loader #2037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c5f22cd
[loader] add __getFunction method
MaxGraey 3c1bff0
add test
MaxGraey e5a0822
more
MaxGraey 7628b24
use authors
MaxGraey 9548abe
split to autor and contributors
MaxGraey d106923
check table existing
MaxGraey 7a8bc43
refactor
MaxGraey 33bcebf
refactor
MaxGraey 1163c0d
simplify
MaxGraey 5417434
revert some changes
MaxGraey b510c95
refactorings
MaxGraey e3d761b
fix
MaxGraey b3fd5ab
fix?
MaxGraey 4eb54d1
simplify demangle's loop
MaxGraey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,13 +34,22 @@ const ARRAYBUFFERVIEW_SIZE = 12; | |
const ARRAY_LENGTH_OFFSET = 12; | ||
const ARRAY_SIZE = 16; | ||
|
||
const E_NO_EXPORT_TABLE = "Operation requires compiling with --exportTable"; | ||
const E_NO_EXPORT_RUNTIME = "Operation requires compiling with --exportRuntime"; | ||
const F_NO_EXPORT_RUNTIME = () => { throw Error(E_NO_EXPORT_RUNTIME); }; | ||
|
||
const BIGINT = typeof BigUint64Array !== "undefined"; | ||
const THIS = Symbol(); | ||
|
||
const STRING_SMALLSIZE = 192; // break-even point in V8 | ||
const STRING_CHUNKSIZE = 1024; // mitigate stack overflow | ||
const utf16 = new TextDecoder("utf-16le", { fatal: true }); // != wtf16 | ||
|
||
/** polyfill for Object.hasOwn */ | ||
Object.hasOwn = Object.hasOwn || function(obj, prop) { | ||
return Object.prototype.hasOwnProperty.call(obj, prop); | ||
}; | ||
|
||
/** Gets a string from memory. */ | ||
function getStringImpl(buffer, ptr) { | ||
let len = new Uint32Array(buffer)[ptr + SIZE_OFFSET >>> 2] >>> 1; | ||
|
@@ -83,51 +92,44 @@ function preInstantiate(imports) { | |
return extendedExports; | ||
} | ||
|
||
const E_NOEXPORTRUNTIME = "Operation requires compiling with --exportRuntime"; | ||
const F_NOEXPORTRUNTIME = function() { throw Error(E_NOEXPORTRUNTIME); }; | ||
|
||
/** Prepares the final module once instantiation is complete. */ | ||
function postInstantiate(extendedExports, instance) { | ||
const exports = instance.exports; | ||
const memory = exports.memory; | ||
const table = exports.table; | ||
const __new = exports.__new || F_NOEXPORTRUNTIME; | ||
const __pin = exports.__pin || F_NOEXPORTRUNTIME; | ||
const __unpin = exports.__unpin || F_NOEXPORTRUNTIME; | ||
const __collect = exports.__collect || F_NOEXPORTRUNTIME; | ||
const __new = exports.__new || F_NO_EXPORT_RUNTIME; | ||
const __pin = exports.__pin || F_NO_EXPORT_RUNTIME; | ||
const __unpin = exports.__unpin || F_NO_EXPORT_RUNTIME; | ||
const __collect = exports.__collect || F_NO_EXPORT_RUNTIME; | ||
const __rtti_base = exports.__rtti_base; | ||
const getRttiCount = __rtti_base | ||
? function (arr) { return arr[__rtti_base >>> 2]; } | ||
: F_NOEXPORTRUNTIME; | ||
const getRttiCount = __rtti_base ? arr => arr[__rtti_base >>> 2] : F_NO_EXPORT_RUNTIME; | ||
|
||
extendedExports.__new = __new; | ||
extendedExports.__pin = __pin; | ||
extendedExports.__unpin = __unpin; | ||
extendedExports.__collect = __collect; | ||
|
||
/** Gets the runtime type info for the given id. */ | ||
function getInfo(id) { | ||
function getRttInfo(id) { | ||
const U32 = new Uint32Array(memory.buffer); | ||
if ((id >>>= 0) >= getRttiCount(U32)) throw Error(`invalid id: ${id}`); | ||
return U32[(__rtti_base + 4 >>> 2) + (id << 1)]; | ||
} | ||
|
||
/** Gets the runtime base id for the given id. */ | ||
function getRttBase(id) { | ||
const U32 = new Uint32Array(memory.buffer); | ||
const count = getRttiCount(U32); | ||
if ((id >>>= 0) >= count) throw Error(`invalid id: ${id}`); | ||
return U32[(__rtti_base + 4 >>> 2) + id * 2]; | ||
if ((id >>>= 0) >= getRttiCount(U32)) throw Error(`invalid id: ${id}`); | ||
return U32[(__rtti_base + 4 >>> 2) + (id << 1) + 1]; | ||
} | ||
|
||
/** Gets and validate runtime type info for the given id for array like objects */ | ||
function getArrayInfo(id) { | ||
const info = getInfo(id); | ||
const info = getRttInfo(id); | ||
if (!(info & (ARRAYBUFFERVIEW | ARRAY | STATICARRAY))) throw Error(`not an array: ${id}, flags=${info}`); | ||
return info; | ||
} | ||
|
||
/** Gets the runtime base id for the given id. */ | ||
function getBase(id) { | ||
const U32 = new Uint32Array(memory.buffer); | ||
const count = getRttiCount(U32); | ||
if ((id >>>= 0) >= count) throw Error(`invalid id: ${id}`); | ||
return U32[(__rtti_base + 4 >>> 2) + id * 2 + 1]; | ||
} | ||
|
||
/** Gets the runtime alignment of a collection's values. */ | ||
function getValueAlign(info) { | ||
return 31 - Math.clz32((info >>> VAL_ALIGN_OFFSET) & 31); // -1 if none | ||
|
@@ -263,6 +265,15 @@ function postInstantiate(extendedExports, instance) { | |
|
||
extendedExports.__getArrayBuffer = __getArrayBuffer; | ||
|
||
/** Gets a function from poiner which contain table's index. */ | ||
function __getFunction(ptr) { | ||
if (!table) throw Error(E_NO_EXPORT_TABLE); | ||
const index = new Uint32Array(memory.buffer)[ptr >>> 2]; | ||
return table.get(index); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Isn't this slower than passing the function __getFunction(index) {
if (!table) throw Error(E_NO_EXPORT_TABLE);
return table.get(index);
} |
||
|
||
extendedExports.__getFunction = __getFunction; | ||
|
||
/** Copies a typed array's values from the module's memory. */ | ||
function getTypedArray(Type, alignLog2, ptr) { | ||
return new Type(getTypedArrayView(Type, alignLog2, ptr)); | ||
|
@@ -309,7 +320,7 @@ function postInstantiate(extendedExports, instance) { | |
if (id <= getRttiCount(U32)) { | ||
do { | ||
if (id == baseId) return true; | ||
id = getBase(id); | ||
id = getRttBase(id); | ||
} while (id); | ||
} | ||
return false; | ||
|
@@ -373,14 +384,13 @@ export function demangle(exports, extendedExports = {}) { | |
const setArgumentsLength = exports["__argumentsLength"] | ||
? length => { exports["__argumentsLength"].value = length; } | ||
: exports["__setArgumentsLength"] || exports["__setargc"] || (() => { /* nop */ }); | ||
for (let internalName in exports) { | ||
if (!Object.prototype.hasOwnProperty.call(exports, internalName)) continue; | ||
for (let internalName of Object.keys(exports)) { | ||
const elem = exports[internalName]; | ||
let parts = internalName.split("."); | ||
let curr = extendedExports; | ||
while (parts.length > 1) { | ||
let part = parts.shift(); | ||
if (!Object.prototype.hasOwnProperty.call(curr, part)) curr[part] = {}; | ||
if (!Object.hasOwn(curr, part)) curr[part] = {}; | ||
curr = curr[part]; | ||
} | ||
let name = parts[0]; | ||
|
@@ -406,7 +416,7 @@ export function demangle(exports, extendedExports = {}) { | |
name = name.substring(hash + 1); | ||
curr = curr[className].prototype; | ||
if (/^(get|set):/.test(name)) { | ||
if (!Object.prototype.hasOwnProperty.call(curr, name = name.substring(4))) { | ||
if (!Object.hasOwn(curr, name = name.substring(4))) { | ||
let getter = exports[internalName.replace("set:", "get:")]; | ||
let setter = exports[internalName.replace("get:", "set:")]; | ||
Object.defineProperty(curr, name, { | ||
|
@@ -417,7 +427,7 @@ export function demangle(exports, extendedExports = {}) { | |
} | ||
} else { | ||
if (name === 'constructor') { | ||
(curr[name] = (...args) => { | ||
(curr[name] = function(...args) { | ||
setArgumentsLength(args.length); | ||
return elem(...args); | ||
}).original = elem; | ||
|
@@ -430,7 +440,7 @@ export function demangle(exports, extendedExports = {}) { | |
} | ||
} else { | ||
if (/^(get|set):/.test(name)) { | ||
if (!Object.prototype.hasOwnProperty.call(curr, name = name.substring(4))) { | ||
if (!Object.hasOwn(curr, name = name.substring(4))) { | ||
Object.defineProperty(curr, name, { | ||
get: exports[internalName.replace("set:", "get:")], | ||
set: exports[internalName.replace("get:", "set:")], | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,9 @@ | |
], | ||
"version": "0.0.0", | ||
"author": "Daniel Wirtz <[email protected]>", | ||
"contributors": [ | ||
"MaxGraey <[email protected]>" | ||
], | ||
"license": "Apache-2.0", | ||
"homepage": "https://assemblyscript.org", | ||
"repository": { | ||
|
@@ -30,8 +33,8 @@ | |
}, | ||
"scripts": { | ||
"asbuild": "npm run asbuild:default && npm run asbuild:legacy", | ||
"asbuild:default": "node ../../bin/asc tests/assembly/index.ts --binaryFile tests/build/default.wasm --exportRuntime", | ||
"asbuild:legacy": "node ../../bin/asc tests/assembly/index.ts --disable mutable-globals --binaryFile tests/build/legacy.wasm --exportRuntime", | ||
"asbuild:default": "node ../../bin/asc tests/assembly/index.ts --binaryFile tests/build/default.wasm --exportRuntime --exportTable", | ||
"asbuild:legacy": "node ../../bin/asc tests/assembly/index.ts --disable mutable-globals --binaryFile tests/build/legacy.wasm --exportRuntime --exportTable", | ||
"build": "npx esm2umd loader index.js > umd/index.js", | ||
"test": "node tests && node tests/umd" | ||
}, | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See: https://github.com/tc39/proposal-accessible-object-hasownproperty