Add issue and PR templates, clarify guidelines #1297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torch2424
reviewed
May 27, 2020
|
Alright, added a checkbox to PRs (but not to issues, seems overkill) and inserted an emoji so it is at least a little friendly. On new PRs, this is how it looks:
Let me know what you think 🙂 |
|
Merging to get this out of the way. If there are ideas to improve the templates further, feel free to create a follow-up PR :) |
|
Oh yeah this looks great! Glad you merged it 😄 👍 @dcodeIO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to the respective agenda item at our 12th Working Group meeting, this PR adds relatively light issue and PR templates to the repository and clarifies a few points within the contributing guidelines. Here's the diff:
Submitting Pull Requests
[...]
[...]
Please note that if a pull request is rather complicated, i.e. touches lots of internals, or became stale, it is not uncommon that a core contributor performs the final integration to get it done in good conscience while naming you as a co-author.
Thank you!
Doesn't go overboard with the templates yet, and mostly makes sure that everyone is aware up-front of how complicated PRs may evolve in an attempt to avoid disappointment or conflict. Please let me know if this looks good to you! cc @MaxGraey @torch2424 @jtenner @DuncanUszkay1