Decouple the parser from the program #1218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcodeIO
reviewed
Apr 13, 2020
dcodeIO
reviewed
Apr 13, 2020
dcodeIO
reviewed
Apr 13, 2020
dcodeIO
requested changes
Apr 13, 2020
dcodeIO
reviewed
Apr 13, 2020
Make suggested change. Co-Authored-By: Daniel Wirtz <[email protected]>
|
All set! |
dcodeIO
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to make the parser more accessible for others by decoupling the program from the parser by forcing the
Parserclass to accept two arrays instead.This would probably be a breaking change for users of the
Parserclass, but my guess is that people weren't using the Parser class directly to begin with.