Skip to content

Check precondition in CI on PRs only #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Check precondition in CI on PRs only #1185

merged 1 commit into from
Mar 25, 2020

Conversation

dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented Mar 25, 2020

Turned out that the author check in our CI action can use different author email addresses for the PR and the merge, so this PR excludes the author check from merges as well.

@dcodeIO dcodeIO merged commit 87d1a72 into master Mar 25, 2020
@dcodeIO
Copy link
Member Author

dcodeIO commented Mar 25, 2020

Alright, this didn't work. Now doesn't run anything on merge at all :)

dcodeIO added a commit that referenced this pull request Mar 25, 2020
@dcodeIO
Copy link
Member Author

dcodeIO commented Mar 25, 2020

Fixed by a force-push.

@dcodeIO dcodeIO deleted the cipr branch May 14, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant