Skip to content

chore(builder): improvements [arduino] #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 25, 2020
Merged

chore(builder): improvements [arduino] #217

merged 3 commits into from
Feb 25, 2020

Conversation

sleepdefic1t
Copy link
Contributor

Summary

  • move Configuration argument to initial builder constructor.
  • enable passing Configuration arguments to the builder constructor.
  • update the CHANGELOG.

Checklist

  • Ready to be merged

@sleepdefic1t
chore(builder): move config to initial constructor
1887ab3 
- move network configuration to the initial builder constructor.
  - e.g. `builder::Transfer().build(config);` -> `builder::Transfer(config).build();`
- update examples.
@sleepdefic1t
chore(builder): enable passing config arguments to builder
983f595 
Enable passing Configuration constructor arguments to the builder constructor.

- rm `explicit` in `Configuration` constructors.
@sleepdefic1t
Update CHANGELOG.md
3bd8336
@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Feb 24, 2020
@faustbrian faustbrian merged commit b305977 into arduino Feb 25, 2020
@ghost ghost deleted the chore(builder)/improvements-arduino branch February 25, 2020 06:56
@ghost ghost mentioned this pull request Mar 1, 2020
Closed
sleepdefic1t added a commit that referenced this pull request Mar 6, 2020
@sleepdefic1t
release: 1.1.0 [arduino]
57ec8a9 
- added Delegate Resignation Builder and Tests [#208]
- improved transaction builder [#217]
- make htlc claim secret a 32-byte hash [#213]
@sleepdefic1t sleepdefic1t mentioned this pull request Mar 6, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faustbrian faustbrian Awaiting requested review from faustbrian

@kristjank kristjank Awaiting requested review from kristjank

Assignees
No one assigned
Labels
Complexity: Medium Less than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sleepdefic1t @faustbrian