Skip to content

Conversation

sleepdefic1t
Copy link
Contributor

Summary

CodeClimate is no longer used.

  • rm ./codeclimate.yml config file.
  • rm ./.github/workflows/codeclimate.yml workflow config file.

CodeClimate is no longer used.

- rm `./codeclimate.yml` config file.
- rm `./.github/workflows/codeclimate.yml` workflow config file.
@ghost ghost added the Complexity: Low Less than 64 lines changed. label Feb 21, 2020
@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #211 into develop will decrease coverage by 3.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #211      +/-   ##
===========================================
- Coverage   100.00%   96.93%   -3.07%     
===========================================
  Files           61       61              
  Lines         1187     1173      -14     
===========================================
- Hits          1187     1137      -50     
- Misses           0       36      +36     
Impacted Files Coverage Δ
src/transactions/types/ipfs.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/transactions/types/vote.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/transactions/types/assets.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/transactions/types/transfer.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/transactions/types/htlc_lock.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/transactions/types/htlc_claim.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/transactions/types/htlc_refund.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/transactions/types/multi_payment.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/include/cpp-crypto/crypto/message.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/transactions/types/second_signature.hpp 0.00% <0.00%> (-100.00%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f06376c...a9d9dd1. Read the comment docs.

@sleepdefic1t
Copy link
Contributor Author

@faustbrian
You can retrigger that workflow if you'd like,
but that looks like codecov bugging out.

These changes only affect the CodeClimate config and workflow.

This is pretty much identical to C++ Client ArkEcosystemArchive/cpp-client#179;
cov isn't impacted there though.

@faustbrian faustbrian merged commit 8116f13 into develop Feb 22, 2020
@ghost ghost deleted the ci/remove-codeclimate branch February 22, 2020 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Low Less than 64 lines changed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants