test/regression: jsx-max-depth #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@github-actions eslint-remote-tester compare {
rulesUnderTesting: [ 'react/jsx-max-depth' ],
eslintrc: { rules: { 'react/jsx-max-depth': 'error' } },
}Run 5 |
AriPerkkio
force-pushed
the
test/regression
branch
from
b08c930 to
95045a3
Compare
Comparison resultsCompared branches:
Detected 4 new ESLint reports and 1 reports to be not present. Click to expandAdded:Rule: react/jsx-max-depth
20 | <Fade in={isOpen}>
21 | <DialogContent>
> 22 | <Icon icon="cancel" onClick={onClose} popoverText="Close Modal" />
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
23 | <div className="modal_content">{children}</div>
24 | <div className={clxs('modal_buttons', classes.buttons)}>
25 | <Button className="modal_buttons--cancel" onClick={onCancel}>Rule: react/jsx-max-depth
21 | <DialogContent>
22 | <Icon icon="cancel" onClick={onClose} popoverText="Close Modal" />
> 23 | <div className="modal_content">{children}</div>
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
24 | <div className={clxs('modal_buttons', classes.buttons)}>
25 | <Button className="modal_buttons--cancel" onClick={onCancel}>
26 | {cancelMsg ? cancelMsg : 'Cancel'}Rule: react/jsx-max-depth
23 | <div className="modal_content">{children}</div>
24 | <div className={clxs('modal_buttons', classes.buttons)}>
> 25 | <Button className="modal_buttons--cancel" onClick={onCancel}>
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 26 | {cancelMsg ? cancelMsg : 'Cancel'}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 27 | </Button>
| ^^^^^^^^^^^^^^^^^^
28 | <Button className="modal_buttons--accept" onClick={onAccept}>
29 | {acceptMsg ? acceptMsg : 'Accept'}
30 | </Button>Rule: react/jsx-max-depth
26 | {cancelMsg ? cancelMsg : 'Cancel'}
27 | </Button>
> 28 | <Button className="modal_buttons--accept" onClick={onAccept}>
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 29 | {acceptMsg ? acceptMsg : 'Accept'}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 30 | </Button>
| ^^^^^^^^^^^^^^^^^^
31 | </div>
32 | </DialogContent>
33 | </Fade>Removed:Rule: jsx-max-depth
20 | <Fade in={isOpen}>
21 | <DialogContent>
> 22 | <Icon icon="cancel" onClick={onClose} popoverText="Close Modal" />
23 | <div className="modal_content">{children}</div>
24 | <div className={clxs('modal_buttons', classes.buttons)}>
25 | <Button className="modal_buttons--cancel" onClick={onCancel}> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.