-
-
Notifications
You must be signed in to change notification settings - Fork 224
Add live tests for MySQL database connectors with improved CI integration #622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Archmonger <[email protected]>
Co-authored-by: Archmonger <[email protected]>
|
…match PostgreSQL pattern Co-authored-by: Archmonger <[email protected]>
I've addressed both requested changes:
The MySQL live tests now have the same structure and isolation approach as the PostgreSQL tests while maintaining the robust error handling and skipping logic when MySQL is unavailable. Commit: 2a6a7e0 |
Hello @Archmonger, the new version of setup-mysql v0.0.4 is now available with the fix! |
Much appreciated! |
This PR implements comprehensive live functional tests for MySQL database connectors, addressing the gap where MySQL tests were previously only mocked while PostgreSQL and SQLite had full end-to-end testing.
Key Changes
MySQL Live Test Implementation:
scripts/mysql_live_test.py
following the established PostgreSQL test pattern with subprocess isolationEnhanced CI/CD Integration:
setup-mysql
action instead of manual setupFramework Integration:
hatch run functional:all
Test Coverage:
MysqlDumpConnector
with actual database operationsUsage Examples
The implementation ensures MySQL connectors receive the same rigorous testing as other database backends, improving reliability and maintaining consistency across the test infrastructure.
Fixes #621.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.