Refactor flushing #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asically either Op::SEND or Op::GET (put or get - both sends). Still lots of debug output
…d flush receive queues. This is important to expose to external applications, as they might need to flush either send or receive queues. E.g. channels have producers or consumers, respectively
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate the flushing, which was previously only for sender queue, into two flush operations:
-lpf_flush_sent
-lpf_flush_received
This is important to have, as some applications separately need to flush send and receive queues, e.g. channels with producers and consumers. It is very important to provide both, as without e.g. lpf_flush_received, it is possible for the application to freeze, being unable to find available slots due to lack of
ibv_post_srq_recvcalls.