Added a styled Button in examples/buttons #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akuli
reviewed
Oct 3, 2021
There was a problem hiding this comment.
The examples/buttons/ directory should only contain files used in buttons.md. Please move this file into examples/, so that it is not in examples/buttons/, and add a comment to the beginning of the file something like this:
# this tutorial doesn't contain anything else about ttk styles yet
Comment on lines
+7
to
+9
| '''Adding Normal Button ''' | ||
| btn1 = Button(root, text = 'Normal Button') | ||
| btn1.pack(pady=20) #pady means padding along y axis |
There was a problem hiding this comment.
Comments like this are not useful and should be deleted. In fact, there is only one useful comment in this file. The code is clearly creating a button, and it is easy to google tkinter pady. If there is too much comments, nobody will read them.
Akuli
reviewed
Oct 3, 2021
| btn2.pack(pady=20) | ||
|
|
||
| '''Notice | ||
| style option inside styled button comes only with ttk not with the normal Tk button |
There was a problem hiding this comment.
This is the only useful comment in the file. It should be shortened though, e.g. # ttk.Button has style option but tkinter.Button doesn't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.